This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
[BZ#1926341] Correctly use namespace from meta.json instead of hard-coded 'openshift-migration' when adding providers #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ft-migration' when adding providers
|
🚀 Deployed Preview: http://konveyor-forklift-ui-pr-414-preview.surge.sh ✨ Compare with current main branch: http://konveyor-forklift-ui-preview.surge.sh |
Codecov Report
@@ Coverage Diff @@
## main #414 +/- ##
=======================================
Coverage 63.58% 63.58%
=======================================
Files 124 124
Lines 3655 3655
Branches 939 939
=======================================
Hits 2324 2324
Misses 1314 1314
Partials 17 17
Continue to review full report at Codecov.
|
ghost
approved these changes
Feb 8, 2021
ghost
merged commit 
mturley
changed the title
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1926341
The namespace
openshift-rhmtvis now being used downstream, but theopenshift-migrationnamespace was hard-coded for the API request to add providers. This caused a 400 error when submitting the add provider form.This PR fixes it by using the same
META.namespacevalue we use in all other API requests so that it can be configured per deployment.