Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Bug 1929050: Allow deleting a Host CR by selecting the Management Network option #427

Merged
2 commits merged into from Feb 24, 2021
Merged

Bug 1929050: Allow deleting a Host CR by selecting the Management Network option #427

2 commits merged into from Feb 24, 2021

Conversation

mturley
Copy link
Collaborator

@mturley mturley commented Feb 16, 2021 •
edited

Resolves #421 (https://bugzilla.redhat.com/show_bug.cgi?id=1929050)
Also resolves #292 (https://bugzilla.redhat.com/show_bug.cgi?id=1908034)

When selecting a migration network for VMware hosts, if the user chooses the management network (and the management network has the same IP for all selected hosts), the credential fields will be disabled (with a tooltip explaining they aren't needed) and upon submission the relevant Host CRs will be deleted, if any.

Screen Shot 2021-02-16 at 2 55 39 PM

Also, a host without a CR will now display "Management Network" with its correct bandwidth and MTU in the table instead of just "(default)".

Screen Shot 2021-02-16 at 3 06 16 PM

@mturley mturley requested a review from a team February 16, 2021 20:05
@github-actions
Copy link

valid bug 1929050

@konveyor-preview-bot
Copy link

🚀 Deployed Preview: http://konveyor-forklift-ui-pr-427-preview.surge.sh ✨

Compare with current main branch: http://konveyor-forklift-ui-preview.surge.sh

@codecov
Copy link

codecov bot commented Feb 16, 2021 •
edited

Codecov Report

Merging #427 (d12c56e) into main (bed1bb7) will decrease coverage by 0.27%.
The diff coverage is 16.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
- Coverage   63.75%   63.47%   -0.28%     
==========================================
  Files         124      124              
  Lines        3755     3776      +21     
  Branches      981      989       +8     
==========================================
+ Hits         2394     2397       +3     
- Misses       1335     1353      +18     
  Partials       26       26
Impacted Files Coverage Δ
src/app/queries/mocks/hosts.mock.ts 100.00% <ø> (ø)
...ers/components/VMwareProviderHostsTable/helpers.ts 13.72% <9.09%> (-0.57%) ⬇️
src/app/queries/hosts.ts 23.68% <16.66%> (-0.61%) ⬇️
...ts/VMwareProviderHostsTable/SelectNetworkModal.tsx 28.26% <21.42%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bed1bb7...d12c56e. Read the comment docs.

@mturley mturley mentioned this pull request Feb 16, 2021
Closed
@mturley mturley marked this pull request as draft February 16, 2021 20:16
@mturley
Copy link
Collaborator Author

mturley commented Feb 16, 2021

Converted to draft. Instead of relying on the name "Management Network" we should use an inventory property to confirm that a network is indeed the default. See #292

@mturley mturley changed the title Bug 1929050: Allow deleting a Host CR by selecting the Management Network option [WIP] Bug 1929050: Allow deleting a Host CR by selecting the Management Network option Feb 16, 2021
@mturley mturley mentioned this pull request Feb 16, 2021
Closed
@mturley mturley added the blocked Requires an update in a dependency label Feb 16, 2021
@mturley
Copy link
Collaborator Author

mturley commented Feb 16, 2021

Blocked by kubev2v/forklift-controller#120.

@mturley
Copy link
Collaborator Author

mturley commented Feb 23, 2021

Now unblocked by kubev2v/forklift-controller#170.

@mturley mturley removed the blocked Requires an update in a dependency label Feb 23, 2021
@mturley mturley changed the title [WIP] Bug 1929050: Allow deleting a Host CR by selecting the Management Network option Bug 1929050: Allow deleting a Host CR by selecting the Management Network option Feb 24, 2021
@mturley mturley marked this pull request as ready for review February 24, 2021 22:28
@mturley
Copy link
Collaborator Author

mturley commented Feb 24, 2021

@fdupont-redhat @gildub this one is now ready as well.

@ghost ghost merged commit 72809c5 into kubev2v:main Feb 24, 2021
@mturley mturley deleted the 421-unset-host-cr branch February 24, 2021 22:31
apinnick added a commit to kubev2v/forklift-documentation that referenced this pull request Mar 31, 2021
@apinnick
kubev2v/forklift-ui#427: Deselect VMware network by selecting default…
11f0849 
… management network.
apinnick added a commit to kubev2v/forklift-documentation that referenced this pull request Apr 1, 2021
@apinnick
kubev2v/forklift-ui#427: Deselect VMware network by selecting default…
f4b5905 
… management network.
apinnick added a commit to kubev2v/forklift-documentation that referenced this pull request Apr 7, 2021
@apinnick
kubev2v/forklift-ui#427: Deselect VMware network by selecting default…
d68f824 
… management network.
apinnick added a commit to kubev2v/forklift-documentation that referenced this pull request Apr 7, 2021
@apinnick
kubev2v/forklift-ui#427: Deselect VMware network by selecting default…
65390c5 
… management network.
apinnick added a commit to kubev2v/forklift-documentation that referenced this pull request Apr 21, 2021
@apinnick
# This is a combination of 23 commits.
4b5b90a 
parent c3c25cd
author Avital Pinnick <apinnick@redhat.com> 1615124047 +0200
committer Avital Pinnick <apinnick@redhat.com> 1619012243 +0300

# This is a combination of 19 commits.
parent c3c25cd
author Avital Pinnick <apinnick@redhat.com> 1615124047 +0200
committer Avital Pinnick <apinnick@redhat.com> 1619012198 +0300

# This is a combination of 17 commits.
# This is the 1st commit message:

BZ1931536: Uninstall MTV in UI

# This is the commit message #2:

markup fix

# This is the commit message #3:

update index

# This is the commit message #4:

Use latest VDDK

# This is the commit message #5:

Changed references from ESXi to vCenter when adding source provider

# This is the commit message #6:

updated example fqdn to include 'vcenter'

# This is the commit message #7:

keywords

# This is the commit message #8:

keywords

# This is the commit message #9:

added contributing.md

# This is the commit message #10:

Update README.md
# This is the commit message #11:

Replace busybox with UBI for VDDK image build

# This is the commit message #12:

Revert "Update version"

2.0.0 release

# This is the commit message #13:

Update field names for selecting VMware network (ESXi host)

# This is the commit message #14:

kubev2v/forklift-ui#427: Deselect VMware network by selecting default management network.

# This is the commit message #15:

fix conflict

# This is the commit message #16:

kubev2v/forklift-ui#427: Deselect VMware network by selecting default management network.

# This is the commit message #17:

Revert "Update version"

2.0.0 release

# This is the commit message #18:

kubev2v/forklift-ui#427: Deselect VMware network by selecting default management network.

# This is the commit message #19:

Revert "Update version"

2.0.0 release

# This is the commit message #21:

kubev2v/forklift-ui#427: Deselect VMware network by selecting default management network.

# This is the commit message #22:

Replace busybox with UBI for VDDK image build

# This is the commit message #23:

removed beta refs
apinnick added a commit to kubev2v/forklift-documentation that referenced this pull request Apr 21, 2021
@apinnick
# This is a combination of 26 commits.
3145d4b 
parent c3c25cd
author Avital Pinnick <apinnick@redhat.com> 1615124047 +0200
committer Avital Pinnick <apinnick@redhat.com> 1619012243 +0300

# This is a combination of 19 commits.
parent c3c25cd
author Avital Pinnick <apinnick@redhat.com> 1615124047 +0200
committer Avital Pinnick <apinnick@redhat.com> 1619012198 +0300

# This is a combination of 17 commits.
# This is the 1st commit message:

BZ1931536: Uninstall MTV in UI

# This is the commit message #2:

markup fix

# This is the commit message #3:

update index

# This is the commit message #4:

Use latest VDDK

# This is the commit message #5:

Changed references from ESXi to vCenter when adding source provider

# This is the commit message #6:

updated example fqdn to include 'vcenter'

# This is the commit message #7:

keywords

# This is the commit message #8:

keywords

# This is the commit message #9:

added contributing.md

# This is the commit message #10:

Update README.md
# This is the commit message #11:

Replace busybox with UBI for VDDK image build

# This is the commit message #12:

Revert "Update version"

2.0.0 release

# This is the commit message #13:

Update field names for selecting VMware network (ESXi host)

# This is the commit message #14:

kubev2v/forklift-ui#427: Deselect VMware network by selecting default management network.

# This is the commit message #15:

fix conflict

# This is the commit message #16:

kubev2v/forklift-ui#427: Deselect VMware network by selecting default management network.

# This is the commit message #17:

Revert "Update version"

2.0.0 release

# This is the commit message #18:

kubev2v/forklift-ui#427: Deselect VMware network by selecting default management network.

# This is the commit message #19:

Revert "Update version"

2.0.0 release

# This is the commit message #21:

kubev2v/forklift-ui#427: Deselect VMware network by selecting default management network.

# This is the commit message #22:

Replace busybox with UBI for VDDK image build

# This is the commit message #23:

removed beta refs

# This is the commit message #24:

Added operator-name attribute

# This is the commit message #26:

BZ1945328: Delete OAuthClient in CLI uninstall
apinnick added a commit to apinnick/forklift-documentation that referenced this pull request May 2, 2021
@apinnick
kubev2v/forklift-ui#427: Deselect VMware network by selecting default…
f59f926 
… management network.
apinnick added a commit to apinnick/forklift-documentation that referenced this pull request May 3, 2021
@apinnick
# This is a combination of 21 commits.
a635e3a 
parent c373729
author Avital Pinnick <apinnick@redhat.com> 1615383858 +0200
committer Avital Pinnick <apinnick@redhat.com> 1620035219 +0300

# This is a combination of 17 commits.
parent c373729
author Avital Pinnick <apinnick@redhat.com> 1615383858 +0200
committer Avital Pinnick <apinnick@redhat.com> 1620035195 +0300

# This is a combination of 15 commits.
# This is the 1st commit message:

update index

# This is the commit message kubev2v#2:

Use latest VDDK

# This is the commit message kubev2v#3:

Changed references from ESXi to vCenter when adding source provider

# This is the commit message kubev2v#4:

updated example fqdn to include 'vcenter'

# This is the commit message kubev2v#5:

keywords

# This is the commit message kubev2v#6:

keywords

# This is the commit message kubev2v#7:

added contributing.md

# This is the commit message kubev2v#8:

Update README.md
# This is the commit message kubev2v#9:

Replace busybox with UBI for VDDK image build

# This is the commit message kubev2v#10:

Revert "Update version"

2.0.0 release

# This is the commit message kubev2v#11:

Update field names for selecting VMware network (ESXi host)

# This is the commit message kubev2v#12:

kubev2v/forklift-ui#427: Deselect VMware network by selecting default management network.

# This is the commit message kubev2v#13:

fix conflict

# This is the commit message kubev2v#14:

kubev2v/forklift-ui#427: Deselect VMware network by selecting default management network.

# This is the commit message kubev2v#15:

Revert "Update version"

2.0.0 release

# This is the commit message kubev2v#16:

kubev2v/forklift-ui#427: Deselect VMware network by selecting default management network.

# This is the commit message kubev2v#17:

Revert "Update version"

2.0.0 release

# This is the commit message kubev2v#19:

kubev2v/forklift-ui#427: Deselect VMware network by selecting default management network.

# This is the commit message kubev2v#20:

Replace busybox with UBI for VDDK image build

# This is the commit message kubev2v#21:

removed beta refs
apinnick added a commit to apinnick/forklift-documentation that referenced this pull request May 5, 2021
@apinnick
kubev2v/forklift-ui#427: Deselect VMware network by selecting default…
ba49344 
… management network.
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mturley @konveyor-preview-bot