This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
Bug 1908745: Add Help dropdown with About modal and documentation link #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
valid bug 1908745 |
|
🚀 Deployed Preview: http://konveyor-forklift-ui-pr-484-preview.surge.sh ✨ Compare with current main branch: http://konveyor-forklift-ui-preview.surge.sh |
Codecov Report
@@ Coverage Diff @@
## main #484 +/- ##
==========================================
+ Coverage 60.20% 60.26% +0.05%
==========================================
Files 131 133 +2
Lines 4227 4263 +36
Branches 1046 1050 +4
==========================================
+ Hits 2545 2569 +24
- Misses 1660 1672 +12
Partials 22 22
Continue to review full report at Codecov.
|
mturley
added a commit
to mturley/forklift-ui
that referenced
this pull request
Mar 26, 2021
gildub
pushed a commit
that referenced
this pull request
Mar 26, 2021
|
Note: this was part 1 of #470, there will be a followup PR to close that issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1908745
Adds a help icon to the left of the brand logo on the right side of the header. Clicking it opens a dropdown with options for "Documentation" (a link to the MTV product docs) and "About". Clicking About opens a modal showing branding and various version numbers.
The Forklift-branded version uses the full Forklift logo from https://github.com/konveyor/community/tree/main/brand/logo in place of a brand icon and text product name. The MTV-branded version uses a small Red Hat icon and the product name in text.
Forklift-branded About modal
MTV-branded About modal