This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
Bug 1977657 - Concatenate Service Signing CA to global CA bundle #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
Kudos, SonarCloud Quality Gate passed!
|
ghost
mentioned this pull request
|
🚀 Deployed Preview: http://konveyor-forklift-ui-pr-680-preview.surge.sh ✨ Compare with current main branch: http://konveyor-forklift-ui-preview.surge.sh |
fbladilo
approved these changes
Jul 2, 2021
mturley
pushed a commit
to mturley/forklift-ui
that referenced
this pull request
Jul 2, 2021
ghost
pushed a commit
that referenced
this pull request
Jul 2, 2021
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OpenShift 4.8, the
service-ca.crtfile contains only one CA certificate, the one for Service Serving Certificates, and this breaks the ability for NodeJS to verify Kubernetes API certificate. Previously, all the internal CA certificates were present inservice-ca.crt. Now, they are only present inca.crt.This pull request creates an entrypoint script that concatenates the
service-ca.crtto theca.crtbundle, if it exists. A parallel pull request, kubev2v/forklift-operator#131, changes theNODE_EXTRA_CA_CERTSenvironment variable of the UI container to point toca.crt, so that it uses the CA bundle with all the internal CAs and the Service Service CA.