Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Bug 1994042: feat(tooltip): add tooltip info to assist with crafting sa token #752

Merged
merged 2 commits into from Aug 26, 2021

Conversation

seanforyou23
Copy link
Contributor

This PR adds some description text and updates the popover text for the service account token field in the add provider modal. Should help close #751 and bz-1994042.

Screen Shot 2021-08-25 at 9 36 43 AM

@seanforyou23 seanforyou23 requested review from gildub, fbladilo, vconzola and a user August 25, 2021 14:35
@konveyor-preview-bot
Copy link

🚀 Deployed Preview: http://konveyor-forklift-ui-pr-752-preview.surge.sh

Compare with current main branch: http://konveyor-forklift-ui-preview.surge.sh

Copy link

@vconzola vconzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@seanforyou23 seanforyou23 changed the title Bug: 1994042 feat(tooltip): add tooltip info to assist with crafting sa token Bug 1994042: feat(tooltip): add tooltip info to assist with crafting sa token Aug 26, 2021
@github-actions
Copy link

Valid bug 1994042

Copy link
Contributor

@gildub gildub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gildub gildub merged commit 51417b8 into kubev2v:main Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tooltip info for tokens where cluster-admin privileges is required
4 participants