This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
Bug 1953253: feat(vms): add an icon indicator to reflect vms power status #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Valid bug 1953253 |
|
🚀 Deployed Preview: http://konveyor-forklift-ui-pr-801-preview.surge.sh ✨ Compare with current main branch: http://konveyor-forklift-ui-preview.surge.sh |
mturley
reviewed
Oct 11, 2021
gildub
reviewed
Oct 12, 2021
…l popover and vm migration details page
mturley
reviewed
Oct 12, 2021
mturley
reviewed
Oct 12, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an icon to the VM name column that reflects its power status. With a nested tooltip like this, we no longer get the tippifying of the vm name for free, so I had to double wrap both the icon and the vm name separately to ensure they would both display.
Should help close #594