Bug 2012795: feat(edit): allow editing for plans where no individual VM migration succeeded #810
Conversation
|
Valid bug 2012795 |
|
Kudos, SonarCloud Quality Gate passed!
|
|
🚀 Deployed Preview: http://konveyor-forklift-ui-pr-810-preview.surge.sh ✨ Compare with current main branch: http://konveyor-forklift-ui-preview.surge.sh |
|
The complexity of this one that we still need to address is making sure all our status displays / lists of VMs in a plan still behave properly when the VM list in a plan spec has been edited and no longer matches the VM list in that plan's status (from the last migration). If that turns out to be a pain for us we could ask the backend guys if it's ok to require deleting existing migration CRs when editing a plan, if that would even help. I may be anxious over nothing and it might be easy to manage. I think we use the status list as the source of truth for the VMs that exist in the migration details page, and we just need to use the spec instead and find the matching VMs from status when rendering? maybe? |
gildub
force-pushed
the
reallow-plan-edits
branch
from
d14b418
to
07810ad
Compare
|
SonarCloud Quality Gate failed.
|
|
Closing this for now, can revive the effort later if need be. |
This PR updates the logic around the PlansTable and PlanActionsDropdown to allow for editing a plan assuming none of the VMs have been migrated yet. We anticipate there may be some changes needed elsewhere in the UI, so I'm posting this as a draft first to work out any kinks.