This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
Select VMs table: add filter by VM power state #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bug is not valid because it is in ON_QA and should be one of NEW, ASSIGNED, or POST |
mturley
changed the title
|
🚀 Deployed Preview: http://konveyor-forklift-ui-pr-811-preview.surge.sh ✨ Compare with current main branch: http://konveyor-forklift-ui-preview.surge.sh |
|
SonarCloud Quality Gate failed.
|
seanforyou23
approved these changes
Oct 20, 2021
| <VMNameWithPowerState | ||
| vm={vm} | ||
| sourceProvider={sourceProvider} | ||
| key={`row${rows.length}-${vm.name}`} // Ensure it always re-mounts when table rows change so tooltip state doesn't get messed up |
There was a problem hiding this comment.
👍 nice work identifying the cause of that issue, it can be a tricky bug to hunt down
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@seanforyou23 we missed this when implementing https://bugzilla.redhat.com/show_bug.cgi?id=1953253.
The second commit fixes something weird I was seeing with tooltips: when the rows get rearranged by the filter, the VMNameWithPowerState components weren't getting remounted, so the event handlers weren't being rebound on the Tooltips even though new DOM nodes were being created. I found that if a VM row didn't end up in the same position in the table, its tooltip stopped working. Putting a key in there that is based on the row index and VM name forces it to remount and create new tooltips, which fixes it.