New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: fix signedKey using platform id #4634
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4634 +/- ##
==========================================
- Coverage 61.87% 61.77% -0.11%
==========================================
Files 352 353 +1
Lines 34773 34823 +50
==========================================
- Hits 21517 21513 -4
- Misses 10458 10512 +54
Partials 2798 2798
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| @@ -63,6 +63,7 @@ func (u systemInfoServiceImpl) Get(ctx context.Context) (*model.SystemInfo, erro | |||
| } | |||
| return info, nil | |||
| } | |||
| info.SignedKey = rand.String(32) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will the random string be persistented ?
|
it still has potential risks if we store them as configmap(database). |
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-1.4
git worktree add -d .worktree/backport-4634-to-release-1.4 origin/release-1.4
cd .worktree/backport-4634-to-release-1.4
git checkout -b backport-4634-to-release-1.4
ancref=$(git merge-base 5a241078b7708893eb1381eee13494ef7929de3b 7c6db17a7fce94881f6d1a61ea6c0430a912f436)
git cherry-pick -x $ancref..7c6db17a7fce94881f6d1a61ea6c0430a912f436 |
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-1.5
git worktree add -d .worktree/backport-4634-to-release-1.5 origin/release-1.5
cd .worktree/backport-4634-to-release-1.5
git checkout -b backport-4634-to-release-1.5
ancref=$(git merge-base 5a241078b7708893eb1381eee13494ef7929de3b 7c6db17a7fce94881f6d1a61ea6c0430a912f436)
git cherry-pick -x $ancref..7c6db17a7fce94881f6d1a61ea6c0430a912f436 |
Signed-off-by: FogDong dongtianxin.tx@alibaba-inc.com
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer
@barnettZQG