-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: parallelize state-keep #5504
Feat: parallelize state-keep #5504
Conversation
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Codecov ReportBase: 47.04% // Head: 59.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5504 +/- ##
===========================================
+ Coverage 47.04% 59.58% +12.54%
===========================================
Files 307 305 -2
Lines 47023 46954 -69
===========================================
+ Hits 22123 27979 +5856
+ Misses 22127 16051 -6076
- Partials 2773 2924 +151
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be backported?
|
no need to backport |
|
But can we have a number of how the effiency up, do we have some pressure test results. |
Added to the description. |
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Signed-off-by: Somefive yd219913@alibaba-inc.com
Description of your changes
Parallelize state-keep to enhance the state-keep efficiency.
Effect: In the load-testing with 3k applications, the average reconcile time could be reduced by 30%~40% while using state-keep. (Each application contains 1 deployment, 1 secret, 1 configmap)
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer