Feat: optimize list operation for resourcetracker and applicationrevision #5572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somefive
requested review from
FogDong,
barnettZQG,
wonderflow,
leejanee and
jefree-cat
as code owners
Somefive
force-pushed
the
feat/optimize-list-op
branch
3 times, most recently
from
ac8e6af
to
2f556db
Compare
Codecov ReportBase: 44.28% // Head: 46.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5572 +/- ##
==========================================
+ Coverage 44.28% 46.67% +2.38%
==========================================
Files 308 254 -54
Lines 47795 43438 -4357
==========================================
- Hits 21167 20274 -893
+ Misses 23900 20870 -3030
+ Partials 2728 2294 -434
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Somefive
force-pushed
the
feat/optimize-list-op
branch
from
2f556db
to
6f2be33
Compare
wonderflow
added
backport release-1.6
wonderflow
changed the title
wonderflow
reviewed
Feb 27, 2023
Compatibility verified. |
wonderflow
approved these changes
Feb 27, 2023
Somefive
force-pushed
the
feat/optimize-list-op
branch
from
6f2be33
to
44b4872
Compare
chivalryq
approved these changes
Feb 27, 2023
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Somefive
force-pushed
the
feat/optimize-list-op
branch
from
44b4872
to
f80777c
Compare
FogDong
approved these changes
Feb 27, 2023
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-1.6
git worktree add -d .worktree/backport-5572-to-release-1.6 origin/release-1.6
cd .worktree/backport-5572-to-release-1.6
git checkout -b backport-5572-to-release-1.6
ancref=$(git merge-base af10f1122512dd542da9f68da5606d11a18a9867 f80777c4a20c539594c400a8e59ada31ef4eba25)
git cherry-pick -x $ancref..f80777c4a20c539594c400a8e59ada31ef4eba25 |
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-1.7
git worktree add -d .worktree/backport-5572-to-release-1.7 origin/release-1.7
cd .worktree/backport-5572-to-release-1.7
git checkout -b backport-5572-to-release-1.7
ancref=$(git merge-base af10f1122512dd542da9f68da5606d11a18a9867 f80777c4a20c539594c400a8e59ada31ef4eba25)
git cherry-pick -x $ancref..f80777c4a20c539594c400a8e59ada31ef4eba25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
When controller handles a large amount of applications, like 50k, the informer cache will hold lots of ResourceTracker and ApplicationRevisions. This will make the list operation on informer cache slow and take lots of CPU.
With this optimization, the cache list time consumption can be reduced from 40ms to 25us, and therefore reduce the overall average reconcile time by 50% under the load-testing settings.
The ResourceTracker list operation is introduced since v1.2 but is lost in v1.6 after the code refactor. This PR fixes it and add additional ApplicationRevision list op optimization for it additionally.
The list op optimization is reached by adding field indexer for these two types of resources.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer