Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BZ 1813198 - change recommended windows bus to sata #148

Merged
merged 1 commit into from May 13, 2020
Merged

Fix BZ 1813198 - change recommended windows bus to sata #148

merged 1 commit into from May 13, 2020

Conversation

glekner
Copy link

@glekner glekner commented May 6, 2020

No description provided.

@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S labels May 6, 2020
@kubevirt-bot
Copy link
Contributor

Hi @glekner. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@glekner glekner changed the title change recommended windows bus to sata Fix BZ 1813198 - change recommended windows bus to sata May 6, 2020
@glekner
Copy link
Author

glekner commented May 6, 2020

@ksimon1 can you review?

MarSik
MarSik suggested changes May 6, 2020
View reviewed changes
templates/win2k12r2-deprecated.tpl.yaml Outdated
"message": "virto disk bus type has better performance, install virtio drivers in VM and change bus type",
"values": ["virtio"],
"message": "sata disk bus type has native support",
"values": ["sata"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not fix the bug from the title. The section you modified is just validation that prints out a warning to the user. It does not affect defaults.

The defaults are set elsewhere (line 119) and are already set to sata.

This change is also wrong. As far as I remember we want users to use virtio for disks, because that bus type has much better performance. The validation can be improved to not match cdroms of course, but it should still match disks I think.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the response @MarSik
There was a misunderstanding from my end, ultimately we want to force only CDs on Windows VMs to SATA only. we can for now force it in the UI but I believe there should be bus validations for CDs in common-templates. please correct me if i'm wrong.
If so, how do we proceed? should I open a bugzilla for it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add a second validation rule with the content you tried to change here, just update the jsonpath to "path": "jsonpath::.spec.domain.devices.disks[*].cdrom.bus",. Double check the cdrom format though as I have been away from kubevirt for many months.

@glekner
Copy link
Author

glekner commented May 12, 2020

@MarSik can you take a look again? Thanks!

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels May 12, 2020
@glekner glekner mentioned this pull request May 12, 2020
Merged
@ksimon1
Copy link
Member

ksimon1 commented May 12, 2020

/ok-to-test

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 12, 2020
@ksimon1
Copy link
Member

ksimon1 commented May 13, 2020

/lgtm
/approve

@ksimon1 ksimon1 merged commit 506c4fa into kubevirt:master May 13, 2020
@glekner
Copy link
Author

glekner commented May 13, 2020

@ksimon1 will this be included in 4.5? Thanks

@ksimon1
Copy link
Member

ksimon1 commented May 13, 2020

yes, this should fix be available in 4.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarSik MarSik MarSik requested changes

@ksimon1 ksimon1 ksimon1 approved these changes

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@glekner @kubevirt-bot @ksimon1 @MarSik