Get rid of DataImportCron finalizer

[arnongilboa]

Signed-off-by: Arnon Gilboa agilboa@redhat.com

What this PR does / why we need it:
Simplify the deletion of CDI and detaching it from cdi-deployment, so we won't need the DataImportCron controller to stay there to remove DataImportCrons finalizer so they can be deleted.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

[brybacki]

All tests failed! Is it a code problem or something in environment?
@arnongilboa can you check it?

[arnongilboa]

All tests failed! Is it a code problem or something in environment? @arnongilboa can you check it?

@brybacki my fault

[arnongilboa]

/retest

[arnongilboa]

/retest

[arnongilboa]

/retest

[awels]

/test pull-containerized-data-importer-e2e-k8s-1.22-hpp-destructive

[awels]

/test pull-containerized-data-importer-e2e-k8s-1.21-ceph

[arnongilboa]

/retest

[arnongilboa]

/cherrypick release-v1.43

[kubevirt-bot]

@arnongilboa: once the present PR merges, I will cherry-pick it on top of release-v1.43 in a new PR and assign it to you.

In response to this:

/cherrypick release-v1.43

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mhenriks]

/lgtm
/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mhenriks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[awels]

/test pull-containerized-data-importer-e2e-k8s-1.22-hpp

[awels]

/override pull-containerized-data-importer-e2e-k8s-1.22-upg

[kubevirt-bot]

@awels: Overrode contexts on behalf of awels: pull-containerized-data-importer-e2e-k8s-1.22-upg

In response to this:

/override pull-containerized-data-importer-e2e-k8s-1.22-upg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[awels]

/test pull-containerized-data-importer-e2e-k8s-1.22-hpp-destructive

[awels]

/test pull-containerized-data-importer-e2e-k8s-1.22-nfs

[awels]

/override pull-containerized-data-importer-e2e-k8s-1.21-ceph

[kubevirt-bot]

@awels: Overrode contexts on behalf of awels: pull-containerized-data-importer-e2e-k8s-1.21-ceph

In response to this:

/override pull-containerized-data-importer-e2e-k8s-1.21-ceph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[awels]

/retest

[kubevirt-bot]

@arnongilboa: #2144 failed to apply on top of branch "release-v1.43":

Applying: Get rid of DataImportCron finalizer
Using index info to reconstruct a base tree...
M	pkg/controller/dataimportcron-controller.go
M	pkg/controller/dataimportcron-controller_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/controller/dataimportcron-controller_test.go
Auto-merging pkg/controller/dataimportcron-controller.go
CONFLICT (content): Merge conflict in pkg/controller/dataimportcron-controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Get rid of DataImportCron finalizer
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-v1.43

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.