Expose an environmental value to virtio win image #1222

tiraboschi · 2021-03-31T08:57:24Z

Expose an environmental value to consume at runtime
a virtio win image that should be propagated to
a config map consumed by the UI component
when the user tries to boot/import a Windows VM.

In the past the UI was using an hardcoded value
but due to that it wasn't properly working on
disconnected environments.

Fixes: https://bugzilla.redhat.com/1942839

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Release note:

Expose an environmental value to virtio win image

coveralls · 2021-03-31T09:46:30Z

Pull Request Test Coverage Report for Build 704926113

5 of 8 (62.5%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.03%) to 72.823%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/controller/operands/vmImport.go	5	8	62.5%

Files with Coverage Reduction	New Missed Lines	%
pkg/controller/operands/vmImport.go	1	82.58%

Totals
Change from base Build 704883441:	0.03%
Covered Lines:	2827
Relevant Lines:	3882

💛 - Coveralls

hco-bot · 2021-03-31T10:52:51Z

hco-e2e-upgrade-prev-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-azure
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-upgrade-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-azure

kubevirt-bot · 2021-03-31T10:53:04Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-azure, ci/prow/hco-e2e-upgrade-prev-azure

In response to this:

hco-e2e-upgrade-prev-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-azure
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-upgrade-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-03-31T11:05:35Z

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp
okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-azure

kubevirt-bot · 2021-03-31T11:05:40Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/okd-hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp
okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

deploy/images.csv

Expose an enviromental value to consume at runtime a virtio win image that should be propagated to a config map consumed by the UI component when the user tries to boot/import a Windows VM. In the past the UI was using an hardcoded value but due to that it wasn't properly working on disconnected enviroments. Fixes: https://bugzilla.redhat.com/1942839 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

sonarcloud · 2021-03-31T12:19:18Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

hco-bot · 2021-03-31T13:42:30Z

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-upgrade-prev-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-aws

kubevirt-bot · 2021-03-31T13:42:37Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-prev-aws

In response to this:

hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-upgrade-prev-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-03-31T13:54:16Z

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-azure

kubevirt-bot · 2021-03-31T13:54:24Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-azure

In response to this:

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2021-03-31T14:40:19Z

/test hco-e2e-kv-smoke-azure

kubevirt-bot · 2021-03-31T14:47:17Z

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.19

Use /test all to run all jobs.

In response to this:

/test hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-03-31T16:50:44Z

@tiraboschi: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/okd-hco-e2e-image-index-azure	`236b8ae`	link	`/test okd-hco-e2e-image-index-azure`
ci/prow/hco-e2e-image-index-gcp	`236b8ae`	link	`/test hco-e2e-image-index-gcp`
ci/prow/hco-e2e-kv-smoke-gcp	`236b8ae`	link	`/test hco-e2e-kv-smoke-gcp`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tiraboschi · 2021-04-01T07:06:12Z

/test hco-e2e-kv-smoke-azure

kubevirt-bot · 2021-04-01T07:06:15Z

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.19

Use /test all to run all jobs.

In response to this:

/test hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

erkanerol · 2021-04-01T07:47:25Z

/lgtm

erkanerol · 2021-04-01T08:33:07Z

/approve

kubevirt-bot · 2021-04-01T08:33:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erkanerol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [erkanerol]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hco-bot · 2021-04-01T09:12:41Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-04-01T09:12:46Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Expose an enviromental value to consume at runtime a virtio win image that should be propagated to a config map consumed by the UI component when the user tries to boot/import a Windows VM. In the past the UI was using an hardcoded value but due to that it wasn't properly working on disconnected enviroments. Fixes: https://bugzilla.redhat.com/1942839 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

tiraboschi · 2021-06-09T15:59:16Z

/cherry-pick release-1.3

kubevirt-bot · 2021-06-09T15:59:20Z

@tiraboschi: #1222 failed to apply on top of branch "release-1.3":

Using index info to reconstruct a base tree...
M	deploy/images.csv
M	deploy/images.env
A	deploy/index-image/community-kubevirt-hyperconverged/1.4.0/manifests/kubevirt-hyperconverged-operator.v1.4.0.clusterserviceversion.yaml
A	deploy/olm-catalog/community-kubevirt-hyperconverged/1.4.0/manifests/kubevirt-hyperconverged-operator.v1.4.0.clusterserviceversion.yaml
M	deploy/operator.yaml
M	hack/build-manifests.sh
M	pkg/components/components.go
M	pkg/controller/commonTestUtils/testUtils.go
M	pkg/controller/hyperconverged/hyperconverged_controller_test.go
M	pkg/controller/operands/operandHandler_test.go
M	pkg/controller/operands/vmImport.go
M	pkg/controller/operands/vmImport_test.go
M	tools/csv-merger/csv-merger.go
M	tools/manifest-templator/manifest-templator.go
Falling back to patching base and 3-way merge...
Auto-merging tools/manifest-templator/manifest-templator.go
CONFLICT (content): Merge conflict in tools/manifest-templator/manifest-templator.go
Auto-merging tools/csv-merger/csv-merger.go
CONFLICT (content): Merge conflict in tools/csv-merger/csv-merger.go
Auto-merging pkg/controller/operands/vmImport_test.go
CONFLICT (content): Merge conflict in pkg/controller/operands/vmImport_test.go
Auto-merging pkg/controller/operands/vmImport.go
CONFLICT (content): Merge conflict in pkg/controller/operands/vmImport.go
Auto-merging pkg/controller/operands/operandHandler_test.go
Auto-merging pkg/controller/hyperconverged/hyperconverged_controller_test.go
CONFLICT (content): Merge conflict in pkg/controller/hyperconverged/hyperconverged_controller_test.go
Auto-merging pkg/controller/commonTestUtils/testUtils.go
CONFLICT (content): Merge conflict in pkg/controller/commonTestUtils/testUtils.go
Auto-merging pkg/components/components.go
CONFLICT (content): Merge conflict in pkg/components/components.go
Auto-merging hack/build-manifests.sh
CONFLICT (content): Merge conflict in hack/build-manifests.sh
Auto-merging deploy/operator.yaml
Auto-merging deploy/olm-catalog/community-kubevirt-hyperconverged/1.3.0/manifests/kubevirt-hyperconverged-operator.v1.3.0.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in deploy/olm-catalog/community-kubevirt-hyperconverged/1.3.0/manifests/kubevirt-hyperconverged-operator.v1.3.0.clusterserviceversion.yaml
Auto-merging deploy/index-image/community-kubevirt-hyperconverged/1.3.0/manifests/kubevirt-hyperconverged-operator.v1.3.0.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in deploy/index-image/community-kubevirt-hyperconverged/1.3.0/manifests/kubevirt-hyperconverged-operator.v1.3.0.clusterserviceversion.yaml
Auto-merging deploy/images.env
CONFLICT (content): Merge conflict in deploy/images.env
Auto-merging deploy/images.csv
CONFLICT (content): Merge conflict in deploy/images.csv
error: Failed to merge in the changes.
Patch failed at 0001 Expose an enviromental value to virtio win image

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Expose an enviromental value to consume at runtime a virtio win image that should be propagated to a config map consumed by the UI component when the user tries to boot/import a Windows VM. In the past the UI was using an hardcoded value but due to that it wasn't properly working on disconnected enviroments. Fixes: https://bugzilla.redhat.com/1942839 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

Expose an enviromental value to consume at runtime a virtio win image that should be propagated to a config map consumed by the UI component when the user tries to boot/import a Windows VM. In the past the UI was using an hardcoded value but due to that it wasn't properly working on disconnected enviroments. Fixes: https://bugzilla.redhat.com/1969756 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

tiraboschi requested review from erkanerol and nunnatsa March 31, 2021 08:57

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 31, 2021

kubevirt-bot requested review from thetechnick and yuvalturg March 31, 2021 08:57

kubevirt-bot added the size/M label Mar 31, 2021

yaacov reviewed Mar 31, 2021

View reviewed changes

deploy/images.csv Outdated Show resolved Hide resolved

kubevirt-bot assigned erkanerol Apr 1, 2021

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2021

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2021

kubevirt-bot merged commit a81de01 into kubevirt:master Apr 1, 2021

tiraboschi deleted the virtio_win_sha branch April 1, 2021 09:13

openshift-ci-robot mentioned this pull request Apr 1, 2021

Bug 1942839: Use digest for virtio-win container image openshift/console#8514

Merged

openshift-ci-robot mentioned this pull request Apr 12, 2021

Bug 1942839: Image is now pulled from config map data openshift/console#8549

Merged

openshift-ci-robot mentioned this pull request Apr 21, 2021

Bug 1942839: Fix async return openshift/console#8719

Merged

tiraboschi mentioned this pull request Jun 10, 2021

Expose an enviromental value to virtio win image (#1222) #1385

Merged

11 tasks

Expose an environmental value to virtio win image #1222

Expose an environmental value to virtio win image #1222

tiraboschi commented Mar 31, 2021

coveralls commented Mar 31, 2021 •

edited

hco-bot commented Mar 31, 2021

kubevirt-bot commented Mar 31, 2021

hco-bot commented Mar 31, 2021

kubevirt-bot commented Mar 31, 2021

sonarcloud bot commented Mar 31, 2021

hco-bot commented Mar 31, 2021

kubevirt-bot commented Mar 31, 2021

hco-bot commented Mar 31, 2021

kubevirt-bot commented Mar 31, 2021

tiraboschi commented Mar 31, 2021

kubevirt-bot commented Mar 31, 2021

openshift-ci bot commented Mar 31, 2021 •

edited

tiraboschi commented Apr 1, 2021

kubevirt-bot commented Apr 1, 2021

erkanerol commented Apr 1, 2021 •

edited

erkanerol commented Apr 1, 2021

kubevirt-bot commented Apr 1, 2021

hco-bot commented Apr 1, 2021

kubevirt-bot commented Apr 1, 2021

tiraboschi commented Jun 9, 2021

kubevirt-bot commented Jun 9, 2021

Expose an environmental value to virtio win image #1222

Expose an environmental value to virtio win image #1222

Conversation

tiraboschi commented Mar 31, 2021

coveralls commented Mar 31, 2021 • edited

Pull Request Test Coverage Report for Build 704926113

💛 - Coveralls

hco-bot commented Mar 31, 2021

kubevirt-bot commented Mar 31, 2021

hco-bot commented Mar 31, 2021

kubevirt-bot commented Mar 31, 2021

sonarcloud bot commented Mar 31, 2021

hco-bot commented Mar 31, 2021

kubevirt-bot commented Mar 31, 2021

hco-bot commented Mar 31, 2021

kubevirt-bot commented Mar 31, 2021

tiraboschi commented Mar 31, 2021

kubevirt-bot commented Mar 31, 2021

openshift-ci bot commented Mar 31, 2021 • edited

tiraboschi commented Apr 1, 2021

kubevirt-bot commented Apr 1, 2021

erkanerol commented Apr 1, 2021 • edited

erkanerol commented Apr 1, 2021

kubevirt-bot commented Apr 1, 2021

hco-bot commented Apr 1, 2021

kubevirt-bot commented Apr 1, 2021

tiraboschi commented Jun 9, 2021

kubevirt-bot commented Jun 9, 2021

coveralls commented Mar 31, 2021 •

edited

openshift-ci bot commented Mar 31, 2021 •

edited

erkanerol commented Apr 1, 2021 •

edited