Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.6] Enable PSA FG on Kubevirt #2105

Merged
merged 1 commit into from
Oct 7, 2022
Merged

[release-1.6] Enable PSA FG on Kubevirt #2105

merged 1 commit into from
Oct 7, 2022

Conversation

tiraboschi
Copy link
Member

Enable PSA FG on Kubevirt to be compatible with
k8s >= 1.24 and derivates with PSA in enforcing mode.

Once available also in older versions of Kubevirt, we will have also to backport it to release-1.6
and release-1.7.

This is a manual cherry-pick of #2093

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Release note:

Enable PSA FG on Kubevirt

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 7, 2022
@tiraboschi
Copy link
Member Author

/override pull-hyperconverged-cluster-operator-e2e-k8s-1.21
provider k8s-1.21 got disabled on kubevirt CI, let's ignore it

@kubevirt-bot
Copy link
Contributor

@tiraboschi: Overrode contexts on behalf of tiraboschi: pull-hyperconverged-cluster-operator-e2e-k8s-1.21

In response to this:

/override pull-hyperconverged-cluster-operator-e2e-k8s-1.21
provider k8s-1.21 got disabled on kubevirt CI, let's ignore it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link
Collaborator

coveralls commented Oct 7, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3205078719

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.474%
Totals Coverage Status
Change from base Build 2623969010: 0.0%
Covered Lines: 3863
Relevant Lines: 4573
💛 - Coveralls

@tiraboschi
[release-1.6] Enable PSA FG on Kubevirt
45aea7f 
Enable PSA FG on Kubevirt to be compatible with
k8s >= 1.24 and derivates with PSA in enforcing mode.

Once available also in older versions of Kubevirt,
we will have also to backport it to release-1.6
and release-1.7.

This is a manual cherry-pick of kubevirt#2093

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@machadovilaca
Copy link
Member

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2022
@tiraboschi
Copy link
Member Author

/override pull-hyperconverged-cluster-operator-e2e-k8s-1.21
provider k8s-1.21 got disabled on kubevirt CI, let's ignore it

@kubevirt-bot
Copy link
Contributor

@tiraboschi: Overrode contexts on behalf of tiraboschi: pull-hyperconverged-cluster-operator-e2e-k8s-1.21

In response to this:

/override pull-hyperconverged-cluster-operator-e2e-k8s-1.21
provider k8s-1.21 got disabled on kubevirt CI, let's ignore it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machadovilaca, tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2022
@kubevirt-bot kubevirt-bot merged commit ca5b471 into kubevirt:release-1.6 Oct 7, 2022
@tiraboschi tiraboschi deleted the kv_ps_16 branch October 7, 2022 16:08
@kubevirt-bot kubevirt-bot mentioned this pull request Nov 7, 2022
Merged
11 tasks
tiraboschi added a commit to tiraboschi/hyperconverged-cluster-operator that referenced this pull request Nov 7, 2022
@tiraboschi
Revert "[release-1.6] Enable PSA FG on Kubevirt (kubevirt#2105)"
723bd8e 
This reverts commit ca5b471.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request Nov 15, 2022
@tiraboschi
Revert "[release-1.6] Enable PSA FG on Kubevirt (#2105)" (#2133)
6979d28 
This reverts commit ca5b471.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa Awaiting requested review from nunnatsa

@sradco sradco Awaiting requested review from sradco

Assignees

@machadovilaca machadovilaca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tiraboschi @kubevirt-bot @coveralls @machadovilaca