Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tests/go.mod #2988

Merged
merged 8 commits into from
Jun 10, 2024
Merged

Remove tests/go.mod #2988

merged 8 commits into from
Jun 10, 2024

Conversation

nunnatsa
Copy link
Collaborator

@nunnatsa nunnatsa commented Jun 6, 2024 •
edited

The kubevirt client, used in the functional tests, is conflicting with k8s packages from 1.27. That forced us to write a new go.mod file under tests/ in order to use working k8s packages, and maintain two different dependency trees. This makes the project maintenance more complex, and we are using too old packages in our functional tests with no way to upgrade them.

This PR replaces usages of the kubevirt client in the functional tests, with kubernetes clients. then this PR removes the tests/go.mod file, making the functional test using the same packages as the production code. This change simplifies the code structure and ease the maintenance of the project.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Jira Ticket:

None

Release note:

None

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 6, 2024
@nunnatsa nunnatsa force-pushed the rm-tests-gomod branch 2 times, most recently from 1321806 to 7b96f74 Compare June 7, 2024 06:17
@coveralls
Copy link
Collaborator

coveralls commented Jun 7, 2024 •
edited

Pull Request Test Coverage Report for Build 9412549940

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.79%
Totals Coverage Status
Change from base Build 9403368814: 0.0%
Covered Lines: 5198
Relevant Lines: 6059
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 7, 2024 •
edited

Pull Request Test Coverage Report for Build 9413711914

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.79%
Totals Coverage Status
Change from base Build 9403368814: 0.0%
Covered Lines: 5198
Relevant Lines: 6059
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 7, 2024 •
edited

Pull Request Test Coverage Report for Build 9414379084

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.79%
Totals Coverage Status
Change from base Build 9403368814: 0.0%
Covered Lines: 5198
Relevant Lines: 6059
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 7, 2024 •
edited

Pull Request Test Coverage Report for Build 9414392839

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 85.806%
Totals Coverage Status
Change from base Build 9403368814: 0.02%
Covered Lines: 5199
Relevant Lines: 6059
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 7, 2024 •
edited

Pull Request Test Coverage Report for Build 9414783253

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.79%
Totals Coverage Status
Change from base Build 9403368814: 0.0%
Covered Lines: 5198
Relevant Lines: 6059
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 7, 2024 •
edited

Pull Request Test Coverage Report for Build 9415908986

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.79%
Totals Coverage Status
Change from base Build 9403368814: 0.0%
Covered Lines: 5198
Relevant Lines: 6059
💛 - Coveralls

@nunnatsa nunnatsa force-pushed the rm-tests-gomod branch 2 times, most recently from e90c614 to 93966da Compare June 8, 2024 05:38
@coveralls
Copy link
Collaborator

coveralls commented Jun 8, 2024 •
edited

Pull Request Test Coverage Report for Build 9426561283

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.809%
Totals Coverage Status
Change from base Build 9418562732: 0.0%
Covered Lines: 5200
Relevant Lines: 6060
💛 - Coveralls

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2024
@nunnatsa nunnatsa force-pushed the rm-tests-gomod branch 2 times, most recently from 461a040 to d723bef Compare June 8, 2024 12:50
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2024
@nunnatsa nunnatsa force-pushed the rm-tests-gomod branch 2 times, most recently from 3ca77aa to 1c63380 Compare June 8, 2024 13:02
@nunnatsa nunnatsa changed the title WIP: Remove tests/go.mod Remove tests/go.mod Jun 8, 2024
@nunnatsa
evictionStrategy: replace kv client with k8s client
91909b4 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
consolePlugin: replace kv client with k8s client
ad922bc 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
fix client config
49cc85c 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
common client creation func
389e72d 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
move more e2e test to use k8s client
fb19ed6 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa
remove tests/go.mod
4c45f49 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.9% Duplication on New Code

See analysis details on SonarCloud

@nunnatsa
Copy link
Collaborator Author

/test ci-index-hco-bundle

@kubevirt-bot
Copy link
Contributor

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build-hco-test-utils-image
  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.29
  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.30

Use /test all to run the following jobs that were automatically triggered:

  • pull-hyperconverged-cluster-operator-e2e-k8s-1.29
  • pull-hyperconverged-cluster-operator-e2e-k8s-1.30

In response to this:

/test ci-index-hco-bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nunnatsa
Copy link
Collaborator Author

/test ci-index-hco-bundle

@kubevirt-bot
Copy link
Contributor

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build-hco-test-utils-image
  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.29
  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.30

Use /test all to run the following jobs that were automatically triggered:

  • pull-hyperconverged-cluster-operator-e2e-k8s-1.29
  • pull-hyperconverged-cluster-operator-e2e-k8s-1.30

In response to this:

/test ci-index-hco-bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
@nunnatsa
Copy link
Collaborator Author

/retest

1 similar comment
@nunnatsa
Copy link
Collaborator Author

/retest

@nunnatsa
Copy link
Collaborator Author

/override-bot

@hco-bot
Copy link
Collaborator

hco-bot commented Jun 10, 2024

hco-e2e-upgrade-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-aws
hco-e2e-consecutive-operator-sdk-upgrades-azure lane succeeded.
/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-aws
hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws
hco-e2e-operator-sdk-azure, hco-e2e-operator-sdk-gcp lanes succeeded.
/override ci/prow/hco-e2e-operator-sdk-aws
hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure
hco-e2e-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-aws, ci/prow/hco-e2e-kv-smoke-azure, ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-operator-sdk-sno-aws, ci/prow/hco-e2e-upgrade-operator-sdk-aws, ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws

In response to this:

hco-e2e-upgrade-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-aws
hco-e2e-consecutive-operator-sdk-upgrades-azure lane succeeded.
/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-aws
hco-e2e-upgrade-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws
hco-e2e-operator-sdk-azure, hco-e2e-operator-sdk-gcp lanes succeeded.
/override ci/prow/hco-e2e-operator-sdk-aws
hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure
hco-e2e-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nunnatsa
Copy link
Collaborator Author

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 10, 2024 •
edited

@nunnatsa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-upgrade-operator-sdk-aws 4c45f49 link true /test hco-e2e-upgrade-operator-sdk-aws
ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws 4c45f49 link false /test hco-e2e-upgrade-operator-sdk-sno-aws
ci/prow/hco-e2e-operator-sdk-sno-aws 4c45f49 link false /test hco-e2e-operator-sdk-sno-aws
ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-aws 4c45f49 link true /test hco-e2e-consecutive-operator-sdk-upgrades-aws
ci/prow/hco-e2e-kv-smoke-azure 4c45f49 link true /test hco-e2e-kv-smoke-azure
ci/prow/hco-e2e-operator-sdk-aws 4c45f49 link unknown /test hco-e2e-operator-sdk-aws
ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws 4c45f49 link true /test hco-e2e-upgrade-prev-operator-sdk-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nunnatsa
Copy link
Collaborator Author

/override-bot

@hco-bot
Copy link
Collaborator

hco-bot commented Jun 10, 2024

hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws

In response to this:

hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot merged commit 4e8265f into kubevirt:main Jun 10, 2024
30 checks passed
@nunnatsa nunnatsa deleted the rm-tests-gomod branch June 10, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@assafad assafad Awaiting requested review from assafad

@machadovilaca machadovilaca Awaiting requested review from machadovilaca

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nunnatsa @coveralls @hco-bot @kubevirt-bot @tiraboschi