-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tests/go.mod #2988
Remove tests/go.mod #2988
Conversation
1321806
to
7b96f74
Compare
Pull Request Test Coverage Report for Build 9412549940Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9413711914Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9414379084Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9414392839Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9414783253Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9415908986Details
💛 - Coveralls |
e90c614
to
93966da
Compare
Pull Request Test Coverage Report for Build 9426561283Details
💛 - Coveralls |
461a040
to
d723bef
Compare
3ca77aa
to
1c63380
Compare
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
|
/test ci-index-hco-bundle |
@nunnatsa: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test ci-index-hco-bundle |
@nunnatsa: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/override-bot |
hco-e2e-upgrade-operator-sdk-azure lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-aws, ci/prow/hco-e2e-kv-smoke-azure, ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-operator-sdk-sno-aws, ci/prow/hco-e2e-upgrade-operator-sdk-aws, ci/prow/hco-e2e-upgrade-operator-sdk-sno-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@nunnatsa: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/override-bot |
hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The kubevirt client, used in the functional tests, is conflicting with k8s packages from 1.27. That forced us to write a new go.mod file under tests/ in order to use working k8s packages, and maintain two different dependency trees. This makes the project maintenance more complex, and we are using too old packages in our functional tests with no way to upgrade them.
This PR replaces usages of the kubevirt client in the functional tests, with kubernetes clients. then this PR removes the tests/go.mod file, making the functional test using the same packages as the production code. This change simplifies the code structure and ease the maintenance of the project.
Jira Ticket:
Release note: