Validate updates to the whole .spec stanza #912
Conversation
kubevirt-bot
added
release-note
|
All tests passed |
HCO is supposed to validate updates to its CR also delegating to components operators the validation of the changes it has to propagate (trying to apply them in dry run mode first and committing only if all the involved components accepted it). This was done only for the .spec.worloads stanza, applying the same strategy to the whole .spec stanza. Fixes: https://bugzilla.redhat.com/1893646 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
|
All tests passed |
|
/lgtm /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@tiraboschi: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/override-bot |
|
hco-e2e-upgrade-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.2 |
|
@tiraboschi: new pull request created: #913 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
HCO is supposed to validate updates to its CR
also delegating to components operators the validation
of the changes it has to propagate (trying to apply
them in dry run mode first and committing only if all the
involved components accepted it).
This was done only for the .spec.worloads stanza,
applying the same strategy to the whole .spec stanza.
Fixes: https://bugzilla.redhat.com/1893646
Fixes: #911
Signed-off-by: Simone Tiraboschi stirabos@redhat.com
Release note: