From 5d96e64b289dce2e56beefeb14f314ce909a6720 Mon Sep 17 00:00:00 2001 From: HF Date: Mon, 26 Dec 2022 00:54:39 -0500 Subject: [PATCH] Invalid parsing result shouldn't be put into store Signed-off-by: HF --- pkg/virt-launcher/virtwrap/agent-poller/agent_poller.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/pkg/virt-launcher/virtwrap/agent-poller/agent_poller.go b/pkg/virt-launcher/virtwrap/agent-poller/agent_poller.go index 6d3eb84d6249..83265f3e53ac 100644 --- a/pkg/virt-launcher/virtwrap/agent-poller/agent_poller.go +++ b/pkg/virt-launcher/virtwrap/agent-poller/agent_poller.go @@ -364,48 +364,56 @@ func executeAgentCommands(commands []AgentCommand, con cli.Connection, agentStor interfaces, err := parseInterfaces(cmdResult) if err != nil { log.Log.Errorf("Cannot parse guest agent interface %s", err.Error()) + continue } agentStore.Store(GET_INTERFACES, interfaces) case GET_OSINFO: osInfo, err := parseGuestOSInfo(cmdResult) if err != nil { log.Log.Errorf("Cannot parse guest agent guestosinfo %s", err.Error()) + continue } agentStore.Store(GET_OSINFO, osInfo) case GET_HOSTNAME: hostname, err := parseHostname(cmdResult) if err != nil { log.Log.Errorf("Cannot parse guest agent hostname %s", err.Error()) + continue } agentStore.Store(GET_HOSTNAME, hostname) case GET_TIMEZONE: timezone, err := parseTimezone(cmdResult) if err != nil { log.Log.Errorf("Cannot parse guest agent timezone %s", err.Error()) + continue } agentStore.Store(GET_TIMEZONE, timezone) case GET_USERS: users, err := parseUsers(cmdResult) if err != nil { log.Log.Errorf("Cannot parse guest agent users %s", err.Error()) + continue } agentStore.Store(GET_USERS, users) case GET_FSFREEZE_STATUS: fsfreezeStatus, err := ParseFSFreezeStatus(cmdResult) if err != nil { log.Log.Errorf("Cannot parse guest agent fsfreeze status %s", err.Error()) + continue } agentStore.Store(GET_FSFREEZE_STATUS, fsfreezeStatus) case GET_FILESYSTEM: filesystems, err := parseFilesystem(cmdResult) if err != nil { log.Log.Errorf("Cannot parse guest agent filesystem %s", err.Error()) + continue } agentStore.Store(GET_FILESYSTEM, filesystems) case GET_AGENT: agent, err := parseAgent(cmdResult) if err != nil { log.Log.Errorf("Cannot parse guest agent information %s", err.Error()) + continue } agentStore.Store(GET_AGENT, agent) }