Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upLimit cloud-init userdata size at api server #404
Comments
davidvossel
added
the
kind/enhancement
label
Aug 31, 2017
davidvossel
self-assigned this
Aug 31, 2017
fabiand
added
size/S
topic/virtualization
labels
Sep 15, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Should be easy to solve once #205 is solved |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
fabiand
Oct 23, 2017
Member
@rmohr @davidvossel do you have a hint where this check could live and how an implementation could look?
|
@rmohr @davidvossel do you have a hint where this check could live and how an implementation could look? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
davidvossel
Oct 23, 2017
Member
The check is going to involve intercepting the VirtualMachine object Put/Post requests and validating the CloudInit's userdata field is less than 2k.
cmd/virt-api/virt-api.go is where the http REST endpoint routes are built. pkg/virt-api/rest/kubeproxy.go contains the function used to build the generic http routes for all our objects.
|
The check is going to involve intercepting the VirtualMachine object Put/Post requests and validating the CloudInit's userdata field is less than 2k. cmd/virt-api/virt-api.go is where the http REST endpoint routes are built. pkg/virt-api/rest/kubeproxy.go contains the function used to build the generic http routes for all our objects. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
fabiand
Apr 4, 2018
Member
@davidvossel I suppose this is also something to be covered by the webhook admission controler?
|
@davidvossel I suppose this is also something to be covered by the webhook admission controler? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@fabiand yes this will be handled in the webhook. |
davidvossel commentedAug 31, 2017
•
edited by fabiand
The api-server needs to enforce a limit on how large we'll allow the cloud-init (and other configuration based data) to be before we allow that object to be stored into etcd.
This issue is about limiting the cloud-init payload size within the VM object.