Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up our Describe/Context/It/By usage in unit tests and functional tests #518

Closed
rmohr opened this issue Oct 18, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@rmohr
Copy link
Member

commented Oct 18, 2017

  • Start using multiple Describe blocks instead of Context
  • Start using Context really as Context to Describes
  • Start using the By function in our tests
  • In general go over all our descriptions and update the descriptions to be a nice narrative

See https://onsi.github.io/ginkgo/#organizing-specs-with-containers-describe-and-context for context.

@shiywang

This comment has been minimized.

Copy link
Member

commented Feb 2, 2018

hi @rmohr
I'm a new member of cnv-qe, also a part-time kubernetes reviewer/maintianer, I would like to dig on this one if there's no one else.

@cynepco3hahue

This comment has been minimized.

Copy link
Member

commented Feb 12, 2018

@shiywang Do you work on it? Because I just started to play with reporters and some test names looks like abrakadabra
For example
CloudInit UserData CloudInit Data Source NoCloud should launch ephemeral vm with cloud-init data source NoCloud

@shiywang

This comment has been minimized.

Copy link
Member

commented Feb 12, 2018

hi, @cynepco3hahue currently I'm not working on it, and I might be a little bit procrastinating on this if I would had started on this since my main responsibility is on storage testing, so feel free to take it : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.