Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upGenerate predeployed Kuberntes Images based on kubeadm separately #564
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@cynepco3hahue FYI |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
fabiand
Nov 13, 2017
Member
@rmohr could you explain this issue a little more? The issue and the solution you have in mind.
|
@rmohr could you explain this issue a little more? The issue and the solution you have in mind. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rmohr
Nov 13, 2017
Member
Sure. It has its own complexity to deploy k8s. Kubeadm can have an issue, the newest k8s release can have an issue. Further we need to test against different k8s versions, different open shift versions and (probably) different network providers in the future. Therefore having dedicated jobs, which re-create/update base images with k8s periodically and do basic sanity checks, we can make our testing more resilient against external issues and always have the advantage that the images are already ready for KubeVirt. We also don't have to take care about removing our testing traces from the image, since we can just do a vagrant destroy && vagrant up.
|
Sure. It has its own complexity to deploy k8s. Kubeadm can have an issue, the newest k8s release can have an issue. Further we need to test against different k8s versions, different open shift versions and (probably) different network providers in the future. Therefore having dedicated jobs, which re-create/update base images with k8s periodically and do basic sanity checks, we can make our testing more resilient against external issues and always have the advantage that the images are already ready for KubeVirt. We also don't have to take care about removing our testing traces from the image, since we can just do a vagrant destroy && vagrant up. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rmohr
Nov 13, 2017
Member
For as long as we are using vagrant, we can e.g. do a vagrant up, wait until the provision script succeeds and then upload the result to vagrant cloud with the appropriate version tag. If we move over to do something more like Cockpit does, we can host the images somewhere else.
|
For as long as we are using vagrant, we can e.g. do a vagrant up, wait until the provision script succeeds and then upload the result to vagrant cloud with the appropriate version tag. If we move over to do something more like Cockpit does, we can host the images somewhere else. |
fabiand
added
kind/enhancement
size/M
topic/ci
labels
Nov 14, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Thanks for clarifying this. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@rmohr I think this is done,r ight? |
fabiand
added
the
priority/backlog
label
Apr 4, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Yes done. We only need to officially deprecate vagrant now #844. |
rmohr commentedNov 9, 2017
Goals are: