Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate virtctl commands #1545

Merged
merged 1 commit into from Sep 25, 2018
Merged

Consolidate virtctl commands #1545

merged 1 commit into from Sep 25, 2018

Conversation

gouyang
Copy link
Contributor

@gouyang gouyang commented Sep 25, 2018 •
edited

  • remove '&' from serverInfo
  • add dots in the end of sentences
  • add '()' for each NAME and TYPE
  • use 'virtual machine' instead of 'VirtualMachine'

Signed-off-by: Guohua Ouyang gouyang@redhat.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Enhanced virtctl command's usage and help

@gouyang
Consolidate virtctl commands
26fde06 
  * remove '&' from serverInfo
  * add dots in the end of sentences
  * add '()' for each NAME and TYPE
  * use 'virtual machine' instead of 'VirtualMachine'

Signed-off-by: Guohua Ouyang <gouyang@redhat.com>
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically.
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 25, 2018
@rmohr
Copy link
Member

rmohr commented Sep 25, 2018

ok to test

@rmohr
Copy link
Member

rmohr commented Sep 25, 2018

ci test please

rmohr
rmohr approved these changes Sep 25, 2018
View reviewed changes
Copy link
Member

@rmohr rmohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 👍

@rmohr rmohr merged commit 2daec0e into kubevirt:master Sep 25, 2018
@gouyang gouyang deleted the consolidate_virtctl branch June 3, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmohr rmohr rmohr approved these changes

@alexxa alexxa alexxa approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gouyang @ovirt-infra @rmohr @alexxa @kubevirt-bot