Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cpu pinning #1648

Merged
merged 2 commits into from Oct 24, 2018
Merged

Fix cpu pinning #1648

merged 2 commits into from Oct 24, 2018

Conversation

vladikr
Copy link
Member

@vladikr vladikr commented Oct 24, 2018

What this PR does / why we need it:
Add CAP_SYS_NICE to all vm pods to allow libvirt to call sched_setaffinity()
Libvirt always calls this method each time it executes the qemu process and normally doesn't require the SYS_NICE capability. However, after starting a VM with cpu pinning, starting each next VM will require the process to have the capability to start qemu.

Which issue(s) this PR fixes
Fixes #1622

"NONE"

Signed-off-by: Vladik Romanovsky <vromanso@redhat.com>
…ame node

Signed-off-by: Vladik Romanovsky <vromanso@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M labels Oct 24, 2018
Copy link
Member

@rmohr rmohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladikr looks good. Did we also create a libvirt issue, since libvirt would not have to do that, because the kubelet does it already?

@rmohr rmohr merged commit a0f8b71 into kubevirt:master Oct 24, 2018
vladikr added a commit that referenced this pull request Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

non-dedicated CPU VM remains in scheduled state if starting after dedicated CPU VM
3 participants