New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the operator remove virt-controller generated traces #3006

Merged

kubevirt-bot merged 1 commit into kubevirt:master from rmohr:fix-uninstall-with-operator

Feb 6, 2020

Member

rmohr commented Jan 20, 2020

What this PR does / why we need it:

virt-api registers apiservices and webhooks which it does not delete. On
uninstall during the operator this lead to incomplete uninstalls which
could block future namespace deletions.

While letting still virt-api creating all these objects, let
virt-operator now manage their removal. The control is still not fully
handed over to virt-operator since there are still people using the
manifest-only installation path without the operator.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1491

Special notes for your reviewer:

Release note:

Uninstall via the operator catches now all artifacts. Deleted namespaces should no longer be stuck forever after uninstalling kubevirt correctly.

kubevirt-bot added release-note dco-signoff: yes size/L labels

Member Author

rmohr commented Jan 20, 2020

/hold

Functional test is there but some unit tests are missing.

kubevirt-bot added the do-not-merge/hold label

kubevirt-bot requested review from ILpinto and phoracek

January 20, 2020 16:52

danielBelenky reviewed

View reviewed changes

Member

danielBelenky left a comment

Generally lgtm, just minor questions

pkg/virt-api/api.go Show resolved Hide resolved

danielBelenky self-assigned this

kubevirt-bot added the needs-rebase label


          Let the operator remove virt-controller generated traces

e61863c

virt-api registers apiservices and webhooks which it does not delete. On
uninstall during the operator this lead to incomplete uninstalls which
could block future namespace deletions.

While letting still virt-api creating all these objects, let
virt-operator now manage their removal. The control is still not fully
handed over to virt-operator since there are still people using the
manifest-only installation path without the operator.

Signed-off-by: Roman Mohr <rmohr@redhat.com>

rmohr force-pushed the fix-uninstall-with-operator branch from e7666a8 to e61863c Compare

January 22, 2020 11:15

kubevirt-bot removed the needs-rebase label

Member Author

rmohr commented Jan 22, 2020

/hold cancel

kubevirt-bot removed the do-not-merge/hold label

rmohr commented

View reviewed changes

tests/operator_test.go

@@ @@ -873,6 +873,18 @@ spec: @@
               			By("Sanity Checking Deployments infrastructure is deleted")
               			sanityCheckDeploymentsDeleted()
+              			By("ensuring that namespaces can be successfully created and deleted")

Member Author

rmohr Jan 22, 2020

This should in future prevent that we leave anything behind which can block namespace management.

danielBelenky suggested changes

View reviewed changes

pkg/virt-operator/creation/rbac/operator.go Show resolved Hide resolved

Member Author

rmohr commented Feb 3, 2020

/test pull-kubevirt-e2e-kind-k8s-sriov-1.14.2

Member

danielBelenky commented Feb 3, 2020

/lgtm

kubevirt-bot added the lgtm label

danielBelenky approved these changes

View reviewed changes

Member Author

rmohr commented Feb 3, 2020

/approve

@danielBelenky thx for the review.

Contributor

kubevirt-bot commented Feb 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmohr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rmohr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot added the approved label

kubevirt-commenter-bot commented Feb 3, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

5 similar comments

kubevirt-commenter-bot commented Feb 4, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubevirt-commenter-bot commented Feb 4, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubevirt-commenter-bot commented Feb 5, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubevirt-commenter-bot commented Feb 5, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubevirt-commenter-bot commented Feb 5, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubevirt-commenter-bot commented Feb 6, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubevirt-bot merged commit 962ac47 into kubevirt:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment