Remove domain label from VMI metrics #3500

ArthurSens · 2020-06-01T14:25:29Z

What this PR does / why we need it:
This PR removes domain labels from VMI metrics. They are being removed because they originate from the original metrics implementation where the more useful labels like name and namespace did not exist and now can be removed

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3477

Special notes for your reviewer:

Release note:

This change will possibly break dashboards that use the domain label to identify VMIs. 

action required
Use name and namespace labels instead

dhiller · 2020-06-02T06:50:04Z

@ArthurSens there is one test failing related to metrics in these lanes, maybe you need to adjust the functional test to your changes:

The other three lanes are failing due to unrelated problems we currently have when spinning up docker in docker tests.

ArthurSens · 2020-06-08T12:09:24Z

/retest

ArthurSens · 2020-06-08T17:30:12Z

/retest

ArthurSens · 2020-06-09T09:45:24Z

/retest

openshift-ci-robot · 2020-06-18T11:47:42Z

@ArthurSens: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-azure-nested-virt	`1d3f694`	link	`/test e2e-azure-nested-virt`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

xpivarc · 2020-07-02T07:33:16Z

@ArthurSens Can you squash commits? Anything else you want to do about this?

ArthurSens · 2020-07-02T10:37:34Z

After discussing with @fabiand and @danielBelenky, I think we might want to send a deprecation note about this label before applying this patch, I don't know if it is possible to merge without adding this patch to the next release though

I don't know the procedure for this case 😬

kubevirt-bot · 2020-07-17T13:40:34Z

@ArthurSens: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…s debug issues. Signed-off-by: Alexander Wels <awels@redhat.com>

Ginkgo containers body are evaluated at definition, i.e. at a pre-main stage. Running code at this stage is not recommended as some initializations are occurring only in the test `main` (which is auto-generated by the test framework). An example of such a scenario is the command line flag parsing. Libraries, tested code and the test infra is expected to declare the flags and the parsing is expected to be execute only once (at main usually). This change moves all code that executes in the containers body to the Before* setup bodies, while leaving on the containers body the variable declarations. Signed-off-by: Edward Haas <edwardh@redhat.com>

Current command line flags are setup at `init` but parsed multiple times by each test file. As the flags are bound to global variables and flag parsing should only be executed once (consequent calls are no-op), there is no point to execute the parse more than once. The test framework is expected to execute the parsing in its main function for its own flags, therefore, there should be no need to explicitly parse the flags in the tests. Signed-off-by: Edward Haas <edwardh@redhat.com>

Signed-off-by: Edward Haas <edwardh@redhat.com>

Basic implementation that adds all k8s metadata.labels and metadata.annotations into a metric labels, separated by commas(',') Signed-off-by: arthursens <arthursens2005@gmail.com>