Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Virt apiserver #355

Closed
wants to merge 9 commits into from
Closed

[WIP] Virt apiserver #355

wants to merge 9 commits into from

Conversation

@stu-gott
Copy link
Member

stu-gott commented Aug 3, 2017

  • proposal
  • manifests
  • etcd backend
  • tests updated
  • console/spice ported from virt-api
@stu-gott stu-gott requested a review from rmohr Aug 3, 2017
@stu-gott stu-gott changed the title Virt apiserver [WIP] Virt apiserver Aug 3, 2017
@stu-gott stu-gott force-pushed the stu-gott:virt-apiserver branch 2 times, most recently from 70a697f to 7d9b522 Aug 15, 2017
@stu-gott stu-gott force-pushed the stu-gott:virt-apiserver branch from 7d9b522 to 9454a1d Aug 29, 2017
@fabiand

This comment has been minimized.

Copy link
Member

fabiand commented Aug 31, 2017

Pfeh - This looks good so far.

@mpolednik

This comment has been minimized.

Copy link

mpolednik commented Sep 6, 2017

I believe this feature lacks a proposal. Could you create a doc explaining the scope, which services are affected and how new services would be developed when using the aggregated apiserver? The doc being part of this PR is fine.

@mpolednik mpolednik mentioned this pull request Sep 6, 2017
@stu-gott stu-gott force-pushed the stu-gott:virt-apiserver branch from 9454a1d to c099da2 Sep 6, 2017
@stu-gott stu-gott force-pushed the stu-gott:virt-apiserver branch from c099da2 to 16a3594 Sep 14, 2017
@stu-gott stu-gott force-pushed the stu-gott:virt-apiserver branch from 16a3594 to d613b30 Sep 21, 2017
@stu-gott

This comment has been minimized.

Copy link
Member Author

stu-gott commented Sep 21, 2017

@mpolednik You are correct! I accidentally created this PR a while back, and it's very much a work in progress currently. I'll definitely add a proposal/explanation for these changes before removing the "[WIP]"

volumeMounts:
- mountPath: /var/run/virt-apiserver-cert
name: virt-apiserver-cert
- name: etcd

This comment has been minimized.

Copy link
@jhernand

jhernand Oct 2, 2017

What is the reason for having a separate instance of etcd can't the API server use the same instance than the rest of the cluster? If the administrator of the cluster configures it for high availability and replication of the master, then this separate instance of etcd won't benefit from that, if I understand correctly.

@stu-gott stu-gott force-pushed the stu-gott:virt-apiserver branch from d613b30 to e460266 Oct 9, 2017
stu-gott added 9 commits Aug 29, 2017
Signed-off-by: Stu Gott <sgott@redhat.com>
Signed-off-by: Stu Gott <sgott@redhat.com>
Signed-off-by: Stu Gott <sgott@redhat.com>
Signed-off-by: Stu Gott <sgott@redhat.com>
Signed-off-by: Stu Gott <sgott@redhat.com>
Signed-off-by: Stu Gott <sgott@redhat.com>
Signed-off-by: Stu Gott <sgott@redhat.com>
Signed-off-by: Stu Gott <sgott@redhat.com>
@stu-gott stu-gott force-pushed the stu-gott:virt-apiserver branch from c88335e to 0dadec5 Oct 19, 2017
@fabiand

This comment has been minimized.

Copy link
Member

fabiand commented Jan 10, 2018

Great work, due to the missing in-cluster storage for user API servers we decided to stick with CCRDs for the time being, thus this user API server can be closed.

Once Kubernetes gains in-cluster user API server storage, then we might want to revisit this topic again.

Thanks Stu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.