New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run proxies using arbitratry userid #374

Merged
merged 1 commit into from Aug 23, 2017

Conversation

Projects
None yet
3 participants
@admiyo
Contributor

admiyo commented Aug 17, 2017

For explanation see:
https://docs.openshift.org/latest/creating_images/guidelines.html
Under "Support Arbitrary User IDs"

Run proxiesy using arbitratry userid
For explanation see:
https://docs.openshift.org/latest/creating_images/guidelines.html
Under "Support Arbitrary User IDs"

Signed-off-by:  Adam Young <adam@younglogic.com>
@davidvossel

This comment has been minimized.

Show comment
Hide comment
@davidvossel

davidvossel Aug 18, 2017

Member

I'm curious how you encountered this. Do these containers fail to start without this change in openshift?

Member

davidvossel commented Aug 18, 2017

I'm curious how you encountered this. Do these containers fail to start without this change in openshift?

@fabiand

This comment has been minimized.

Show comment
Hide comment
@fabiand

fabiand Aug 18, 2017

Member

Also - Could we use the runAsUser field of the PodSecurityContext (https://kubernetes.io/docs/api-reference/v1.6/#podsecuritycontext-v1-core) - or SecurityContext for Container.

Member

fabiand commented Aug 18, 2017

Also - Could we use the runAsUser field of the PodSecurityContext (https://kubernetes.io/docs/api-reference/v1.6/#podsecuritycontext-v1-core) - or SecurityContext for Container.

@admiyo admiyo changed the title from Run proxiesy using arbitratry userid to Run proxies using arbitratry userid Aug 18, 2017

@admiyo

This comment has been minimized.

Show comment
Hide comment
@admiyo

admiyo Aug 18, 2017

Contributor

Please read the link in the commit request for the rationale.

Contributor

admiyo commented Aug 18, 2017

Please read the link in the commit request for the rationale.

@admiyo

This comment has been minimized.

Show comment
Hide comment
@admiyo

admiyo Aug 18, 2017

Contributor

Without these changes, the containers fail with permissions errors when deploying on origin.

Contributor

admiyo commented Aug 18, 2017

Without these changes, the containers fail with permissions errors when deploying on origin.

@fabiand fabiand added the kind/bug label Aug 23, 2017

@fabiand

This comment has been minimized.

Show comment
Hide comment
@fabiand

fabiand Aug 23, 2017

Member

Right, lgtm.

Member

fabiand commented Aug 23, 2017

Right, lgtm.

@fabiand

lgtm

@fabiand fabiand merged commit 932d0f7 into kubevirt:master Aug 23, 2017

3 of 4 checks passed

kubevirt-functional-tests/jenkins/pr kubevirt-functional-tests/jenkins/pr
Details
Signed-off-by checker
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 54.769%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment