Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
doc: VM metrics documentation #487
This patch reorganize the content of the vm-metrics proposal, aligning the naming scheme to the one used in https://github.com/kubernetes/community/blob/master/contributors/design-proposals/instrumentation/monitoring_architecture.md Even though the key concepts are the same as the previous version, almost all the document has been rewritten to reframe the concepts in the framework of the monitoring architecture proposal.
stu-gott left a comment
The general message of this seems fine to me. There are a large number of misplaced newlines in this document. This won't show up in a generated web page, but looks odd when viewing in a text editor.
rmohr left a comment
Looks nice over all and it also seems to take into account where k8s wants to go.
What are your plans for integration right now? Using the common plane with custom metrics? Are you also planning to ship our metrics on two different streams? If yes, are there plans based on the k8s proposal, to allow "add-on core metrics"?