Build dockerized #647
mpolednik left a comment
In general, I approve the approach. There are several minor questions inlined, mostly related to how dist actually looks like.
Extra comment could be made about
To avoid commenting every target: with this PR, most of the targets have "hidden" prerequisites: to run cluster-deploy one must run
The target dependencies are probably out of scope of this PR, but it would be nice if some of it could be handled automatically - so for example running cluster-deploy would run all the required steps.
As for the scope of this PR, I welcome the change. Not only it aligns nicely with Kubernetes, but as a side effect now allows builds/tests to be run on different platforms easily.
(the example actually uses Docker's linux-based VM on Darwin, making it possible to rsync the builds to dev machines)
Running that series of commands is not necessary. If the provider is not up, one has to call
They should now all have no hidden dependencies. Could you try the latest state? I don't want to confuse people too much with hidden dependencies.
@rmohr you need to mount the docker socket into the environment and install docker itself.
Basically just add the following to
And additionally add the following to
By also moving the manifests to _out, we have all produced artifacts in the _out folder. Signed-off-by: Roman Mohr <email@example.com>
Only build containers needed for tests, in order to speed up vagrant provisioning. The optional docker containers are just for convenience and not required by tests. Signed-off-by: Roman Mohr <firstname.lastname@example.org>