Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[migrations]: add phase and VMI name to the VMIM CLI output #6836

Merged
merged 2 commits into from Dec 1, 2021
Merged

[migrations]: add phase and VMI name to the VMIM CLI output #6836

merged 2 commits into from Dec 1, 2021

Conversation

enp0s3
Copy link
Contributor

@enp0s3 enp0s3 commented Nov 23, 2021

Signed-off-by: Igor Bezukh ibezukh@redhat.com

What this PR does / why we need it:
In a large scale environment one may find a lots of VMIM resources. When it comes to CLI it is a tedious
task to manually determine the phase of each such resource and the VMI related to it.

Therefore we expose the VMI and PHASE columns

Fixes #
https://bugzilla.redhat.com/show_bug.cgi?id=2017802

Special notes for your reviewer:

Release note:

Added PHASE and VMI columns for the 'kubectl get vmim' CLI output

@enp0s3
VMIM cli output to have VMI and PHASE columns
456d2ce 
In a large scale environment one may find a lots
of VMIM resources. When it comes to CLI it is a tedious
task to manually determine the phase of each such resource
and the VMI related to it.

Therefore we expose the VMI and PHASE columns

Signed-off-by: Igor Bezukh <ibezukh@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 23, 2021
@enp0s3 enp0s3 force-pushed the vmim_add_more_cli_output branch 2 times, most recently from 283b744 to 9b125dc Compare November 23, 2021 12:51
xpivarc
xpivarc reviewed Nov 23, 2021
View reviewed changes
tests/migration_test.go Outdated Show resolved Hide resolved
xpivarc
xpivarc requested changes Nov 24, 2021
View reviewed changes
Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

tests/kubectl_test.go Outdated Show resolved Hide resolved
tests/kubectl_test.go Show resolved Hide resolved
tests/kubectl_test.go Outdated Show resolved Hide resolved
@enp0s3
e2e: test VM instance migration CLI output
7e6ebd4 
Signed-off-by: Igor Bezukh <ibezukh@redhat.com>
@xpivarc
Copy link
Member

xpivarc commented Nov 29, 2021

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2021
@enp0s3
Copy link
Contributor Author

enp0s3 commented Nov 30, 2021

/retest

@enp0s3
Copy link
Contributor Author

enp0s3 commented Nov 30, 2021

/cc @stu-gott

dhiller
dhiller reviewed Nov 30, 2021
View reviewed changes
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit c7eea22 into kubevirt:main Dec 1, 2021
@enp0s3
Copy link
Contributor Author

enp0s3 commented Dec 12, 2021

/cherry-pick release-0.44

@kubevirt-bot kubevirt-bot mentioned this pull request Dec 12, 2021
Merged
@kubevirt-bot
Copy link
Contributor

@enp0s3: new pull request created: #6941

In response to this:

/cherry-pick release-0.44

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhiller dhiller dhiller left review comments

@xpivarc xpivarc xpivarc requested changes

@kbidarkar kbidarkar Awaiting requested review from kbidarkar

@zcahana zcahana Awaiting requested review from zcahana

@stu-gott stu-gott Awaiting requested review from stu-gott

Assignees

@xpivarc xpivarc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@enp0s3 @xpivarc @kubevirt-bot @kubevirt-commenter-bot @dhiller