Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.44] Add logs indicating when global migration limits are hit #7021

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #6950

/assign enp0s3

NONE

Signed-off-by: David Vossel <davidvossel@gmail.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Jan 3, 2022
@xpivarc
Copy link
Member

xpivarc commented Jan 3, 2022

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2022
@dhiller
Copy link
Contributor

dhiller commented Jan 3, 2022

/approve

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2022
@dhiller
Copy link
Contributor

dhiller commented Jan 3, 2022

/approve cancel

@enp0s3 Looks like you need to cherry-pick this manually, as pull-kubevirt-generate seems to complain (didn't look into why that is TBH)

@kubevirt-bot kubevirt-bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2022
@enp0s3
Copy link
Contributor

enp0s3 commented Jan 5, 2022

/hold
lets wait till #7026 merges

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2022
@enp0s3
Copy link
Contributor

enp0s3 commented Jan 5, 2022

/unhold
/retest

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2022
@enp0s3
Copy link
Contributor

enp0s3 commented Jan 6, 2022

/retest

@enp0s3
Copy link
Contributor

enp0s3 commented Jan 6, 2022

@dhiller Hi. The issue with make generate was resolved in #7026 can you please take another look?
TIA

Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks @enp0s3!

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2022
@kubevirt-commenter-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit 3e3e205 into kubevirt:release-0.44 Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants