Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.49] Garbage collect finalized Migration objects #7166

Merged
merged 3 commits into from Feb 2, 2022
Merged

[release-0.49] Garbage collect finalized Migration objects #7166

merged 3 commits into from Feb 2, 2022

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #7144

/assign stu-gott

Garbage collect finalized migration objects only leaving the most recent 5 objects

@davidvossel
garbage collect migrations for vmis
de18f68 
Signed-off-by: David Vossel <davidvossel@gmail.com>
@davidvossel
Unit test verifying migration garbage collection
5456389 
Signed-off-by: David Vossel <davidvossel@gmail.com>
@davidvossel
functional test verifying finalized migrations get garbage collected
2894590 
Signed-off-by: David Vossel <davidvossel@gmail.com>
@kubevirt-bot kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 1, 2022
@kubevirt-bot kubevirt-bot mentioned this pull request Feb 1, 2022
Merged
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Feb 1, 2022
@davidvossel
Copy link
Member

/lgtm
/approve
/retest

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2022
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2022
@kubevirt-bot
Copy link
Contributor Author

kubevirt-bot commented Feb 2, 2022 •
edited

@kubevirt-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-check-tests-for-flakes 2894590 link false /test pull-kubevirt-check-tests-for-flakes-0.49

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@davidvossel
Copy link
Member

/retest

@kubevirt-bot kubevirt-bot merged commit 5ed0816 into kubevirt:release-0.49 Feb 2, 2022
@kubevirt-bot kubevirt-bot mentioned this pull request Aug 30, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ILpinto ILpinto Awaiting requested review from ILpinto

@vladikr vladikr Awaiting requested review from vladikr

Assignees

@davidvossel davidvossel

@stu-gott stu-gott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubevirt-bot @davidvossel @stu-gott