[release-0.58]: Fix: Align Reenlightenment flows between converter.go and template.go #8798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
iholder101
force-pushed
the
manual_backport/fix/reenlightenment-align-flows
branch
2 times, most recently
from
ac91562
to
112ba5c
Compare
iholder101
changed the title
|
/hold |
kubevirt-bot
added
do-not-merge/hold
While the converter.go logic checked whether we have topology hints defined and that tsc frequency is required (which is the right thing to do), template.go logic did not check the later. In addition, improve IsManualTSCFrequencyRequired() to also check whether topology hints are defined. Signed-off-by: Itamar Holder <iholder@redhat.com>
Signed-off-by: Itamar Holder <iholder@redhat.com>
Signed-off-by: Itamar Holder <iholder@redhat.com>
…e updated Signed-off-by: Itamar Holder <iholder@redhat.com>
That's how we can distinguish between us waiting for a TSC frequency and knowing there is no TSC frequency information, hence we can stop waiting for it. This is necessary, since the vmi controller executes "sync()" and "updateStatus()" in every control loop. If TSC frequency is required, sync() would wait until topology hints would be set up by updateStatus(). Today, updateStatus() doesn't update the topology hints at all if no TSC frequency information exists, therefore sync will continue waiting forever and the VM wouldn't be able to start. Signed-off-by: Itamar Holder <iholder@redhat.com>
…gy hints are updated Signed-off-by: Itamar Holder <iholder@redhat.com>
…ined Signed-off-by: Itamar Holder <iholder@redhat.com>
Signed-off-by: Itamar Holder <iholder@redhat.com>
iholder101
force-pushed
the
manual_backport/fix/reenlightenment-align-flows
branch
from
112ba5c
to
03d63fc
Compare
kubevirt-bot
added
size/L
and removed
size/XL
needs-rebase
|
/hold cancel |
kubevirt-bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enp0s3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
fossedihelm
approved these changes
Nov 17, 2022
|
/retest-required |
|
@iholder-redhat: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubevirt-build-0.58 |
|
/retest-required |
|
@iholder101: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/retest-required |
This was referenced Nov 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Manual backport for #8740.
The reason a manual backport is required is because the functional tests are added to hyperv_test.go which didn't exist in
release-58branch because the PR that created this file wasn't backported.Release note: