[release-0.53]: Fix: Align Reenlightenment flows between converter.go and template.go #8996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
|
/cc @enp0s3 can you please take a look? |
kubevirt-bot
added
the
do-not-merge/work-in-progress
iholder101
force-pushed
the
backport/hyperv_reenlightenment_flow_alignment
branch
from
6c64705
to
81c4ff9
Compare
kubevirt-bot
removed
the
do-not-merge/work-in-progress
|
/test pull-kubevirt-unit-test |
|
@iholder101: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubevirt-unit-test-0.53 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enp0s3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
Please divide the first commit to the original commit and another commit with your changes so it will be easier to review. |
These test doesn't require Windows OS to be tested. CI has only one copy of Windows license and therefore limited bw on Windows lane. Signed-off-by: L. Pivarc <lpivarc@redhat.com> Signed-off-by: Itamar Holder <iholder@redhat.com>
The previous commit copied the some functests from windows_tests to hyperv_tests but did not remove some crucial helper functions over there as well. Signed-off-by: Itamar Holder <iholder@redhat.com>
Prove That currently whenever EVMCS HyperV feature Is not nil in the vm spec than all dependencies features are enabled. Even if we set to vmi.Spec.Domain.Features.Hyperv.EVMCS.Enabled to be false. Signed-off-by: bmordeha <bmodeha@redhat.com>
Currently whenever EVMCS HyperV feature Is not nil in the vm spec than all dependencies features are enabled. Even if we set to vmi.Spec.Domain.Features.Hyperv.EVMCS.Enabled to be false. Signed-off-by: bmordeha <bmodeha@redhat.com>
Signed-off-by: bmordeha <bmodeha@redhat.com>
make sure that if we set vmi.Spec.Domain.Features.Hyperv.EVMCS.Enabled to be false than all dependencies features are not enabled. Signed-off-by: bmordeha <bmodeha@redhat.com>
While the converter.go logic checked whether we have topology hints defined and that tsc frequency is required (which is the right thing to do), template.go logic did not check the later. In addition, improve IsManualTSCFrequencyRequired() to also check whether topology hints are defined. Signed-off-by: Itamar Holder <iholder@redhat.com>
Signed-off-by: Itamar Holder <iholder@redhat.com>
Signed-off-by: Itamar Holder <iholder@redhat.com>
…e updated Signed-off-by: Itamar Holder <iholder@redhat.com>
That's how we can distinguish between us waiting for a TSC frequency and knowing there is no TSC frequency information, hence we can stop waiting for it. This is necessary, since the vmi controller executes "sync()" and "updateStatus()" in every control loop. If TSC frequency is required, sync() would wait until topology hints would be set up by updateStatus(). Today, updateStatus() doesn't update the topology hints at all if no TSC frequency information exists, therefore sync will continue waiting forever and the VM wouldn't be able to start. Signed-off-by: Itamar Holder <iholder@redhat.com>
…gy hints are updated Signed-off-by: Itamar Holder <iholder@redhat.com>
…ined Signed-off-by: Itamar Holder <iholder@redhat.com>
iholder101
force-pushed
the
backport/hyperv_reenlightenment_flow_alignment
branch
from
81c4ff9
to
7555f2b
Compare
done |
Barakmor1
reviewed
Dec 26, 2022
Comment on lines
-1880
to
+1881
| // The return value is overhead memory quantity | ||
| // # The return value is overhead memory quantity | ||
| // | ||
| // Note: This is the best estimation we were able to come up with | ||
| // and is still not 100% accurate | ||
| // | ||
| // and is still not 100% accurate |
There was a problem hiding this comment.
nit: i think that these are leftovers
|
/lgtm |
|
/retest |
|
@iholder101: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test pull-kubevirt-e2e-k8s-1.21-sig-performance-0.53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Manual backport of #8798. As a dependency, I've also backported #8793.
The reasons for the manual backport are mostly minor issues.
Release note: