Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rook-cephfs storage class for filesystem PVCs #768

Closed
wants to merge 2 commits into from

Conversation

rmohr
Copy link
Member

@rmohr rmohr commented Mar 23, 2022

If rook-ceph gets enabled, it can now used for filesystem PVCs.

$ kubectl.sh get storageclasses
selecting docker as container runtime
NAME                        PROVISIONER                     RECLAIMPOLICY   VOLUMEBINDINGMODE      ALLOWVOLUMEEXPANSION   AGE
local                       kubernetes.io/no-provisioner    Delete          WaitForFirstConsumer   false                  33m
rook-ceph-block (default)   rook-ceph.rbd.csi.ceph.com      Delete          Immediate              true                   31m
rook-cephfs                 rook-ceph.cephfs.csi.ceph.com   Delete          Immediate              false                  31m

Also bumping the centos-stream base version, since for the initrd of the older kenerl we don't have kernel modules anymore.

If rook-ceph gets enabled, it can now used for filesystem PVCs.

Signed-off-by: Roman Mohr <rmohr@redhat.com>
@rmohr
Copy link
Member Author

rmohr commented Mar 23, 2022

/cc @mhenriks
/cc @akalenyu

I am unsure regarding to allowing resize and if we should make the fs storage class the default.

@rmohr
Copy link
Member Author

rmohr commented Mar 23, 2022

/cc @xpivarc

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Mar 23, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from rmohr after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Roman Mohr <rmohr@redhat.com>
@rmohr
Copy link
Member Author

rmohr commented Mar 24, 2022

/retest

@akalenyu
Copy link
Contributor

Awesome!

The only suggestion I have is that we add a ready check for cephfs similarly to

until kubectl --kubeconfig /etc/kubernetes/admin.conf get cephblockpools -n rook-ceph replicapool -o jsonpath='{.status.phase}' | grep Ready; do

@@ -1 +1 @@
20210210.0
20220125.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just from curiosity why is it needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We provide the kernel from outside the VM. From time to time the kernel module package does no longer exist in the repos anymore and we have to bump to a newer image to use, where we can still find the matching modules in the repo. Let me add it to the commit message.

@rmohr
Copy link
Member Author

rmohr commented Mar 28, 2022

The only suggestion I have is that we add a ready check for cephfs similarly to

Will add it asap 👍

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 26, 2022
@jean-edouard
Copy link
Contributor

/cc

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2022
@kubevirt-bot
Copy link
Contributor

@rmohr: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 19, 2022
@kubevirt-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kubevirt-bot
Copy link
Contributor

@kubevirt-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants