New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rook-cephfs storage class for filesystem PVCs #768
Conversation
If rook-ceph gets enabled, it can now used for filesystem PVCs. Signed-off-by: Roman Mohr <rmohr@redhat.com>
|
/cc @xpivarc |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Roman Mohr <rmohr@redhat.com>
|
/retest |
|
Awesome! The only suggestion I have is that we add a ready check for cephfs similarly to
|
| @@ -1 +1 @@ | |||
| 20210210.0 | |||
| 20220125.1 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just from curiosity why is it needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We provide the kernel from outside the VM. From time to time the kernel module package does no longer exist in the repos anymore and we have to bump to a newer image to use, where we can still find the matching modules in the repo. Let me add it to the commit message.
Will add it asap 👍 |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
|
/cc |
|
@rmohr: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. /close |
|
@kubevirt-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If rook-ceph gets enabled, it can now used for filesystem PVCs.
Also bumping the centos-stream base version, since for the initrd of the older kenerl we don't have kernel modules anymore.