Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirt,presubmit: Enable vgpu presubmits and set to required #3484

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

brianmcarey
Copy link
Member

What this PR does / why we need it:

The vgpu presubmit lanes were disabled following the upgrade of the cluster which caused these lanes to fail constantly[1]

These failures were due to an issue with the version of the vgpu driver installed on the nodes. Updating to a later version of the driver has resolved this issue and the periodic vgpu lane is passing consistently[2].

The vgpu presubmit test lanes can be reintroduced and set as required.

[1] #3408
[2] https://prow.ci.kubevirt.io/job-history/gs/kubevirt-prow/logs/periodic-kubevirt-e2e-kind-1.27-vgpu

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @dhiller @xpivarc

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


The vgpu presubmit lanes were disabled following the upgrade of the
cluster which caused these lanes to fail constantly[1]

These failures were due to an issue with the version of the vgpu driver
installed on the nodes. Updating to a later version of the driver has
resolved this issue and the periodic vgpu lane is passing
consistently[2].

The vgpu presubmit test lanes can be reintroduced and set as required.

[1] kubevirt#3408
[2] https://prow.ci.kubevirt.io/job-history/gs/kubevirt-prow/logs/periodic-kubevirt-e2e-kind-1.27-vgpu

Signed-off-by: Brian Carey <bcarey@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Jun 24, 2024
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you for following up on this, @brianmcarey !

🎉

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2024
@kubevirt-bot kubevirt-bot merged commit c91045b into kubevirt:main Jun 24, 2024
5 checks passed
@kubevirt-bot
Copy link
Contributor

@brianmcarey: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key kubevirt-presubmits-1.0.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits-1.0.yaml
  • key kubevirt-presubmits-1.1.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits-1.1.yaml
  • key kubevirt-presubmits-1.2.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits-1.2.yaml
  • key kubevirt-presubmits-1.3.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits-1.3.yaml
  • key kubevirt-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml

In response to this:

What this PR does / why we need it:

The vgpu presubmit lanes were disabled following the upgrade of the cluster which caused these lanes to fail constantly[1]

These failures were due to an issue with the version of the vgpu driver installed on the nodes. Updating to a later version of the driver has resolved this issue and the periodic vgpu lane is passing consistently[2].

The vgpu presubmit test lanes can be reintroduced and set as required.

[1] #3408
[2] https://prow.ci.kubevirt.io/job-history/gs/kubevirt-prow/logs/periodic-kubevirt-e2e-kind-1.27-vgpu

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @dhiller @xpivarc

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants