[release-v0.17] fix: console proxy and tests: Stabilize functional tests #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions RevertToOriginalSspCr() now wait until SSP is deployed before returning. This is useful, because reverting SSP may change TLS policy, which causes the pod to crash, and it may be some time before it is running again. If in the meantime, another test tries to update the SSP, it will fail, because the webhook cannot be reached. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
When the annotation "ssp.kubevirt.io/vm-console-proxy-enabled" is removed from SSP, the operator removes resources for vm-console-proxy, but previously it did not wait until they were removed. With this chnange, the SSP will not be in "Deployed" state until the resources are removed. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
It may take a moment until the vm-console-proxy is reachable using the Route. This commit wraps the request in an Eventually() loop. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
kubevirt-bot
added
release-note-none
|
CI will not run until this is merged: openshift/release#36425 |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/approve |
|
/hold |
kubevirt-bot
added
the
do-not-merge/hold
|
The CI has passed. |
kubevirt-bot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akrejcir, lyarwood The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of: #527
What this PR does / why we need it:
This PR contains 2 changes to make functional tests less flaky:
Functions
RevertToOriginalSspCr()now wait until SSP is deployed before returning.This is useful, because reverting SSP may change TLS policy, which causes the pod to crash, and it may be some time before it is running again. If in the meantime, another test tries to update the SSP, it will fail, because the webhook cannot be reached.
When the annotation
ssp.kubevirt.io/vm-console-proxy-enabledis removed from SSP CR, the operator waits for resources to be removed before setting thestatus.phasetoDeployed.Release note: