New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registry Disk user-guide update #4
Conversation
Signed-off-by: David Vossel <davidvossel@gmail.com>
Signed-off-by: David Vossel <davidvossel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good usage-guide. A few minor comments.
## When Not to use a Registry Disk | ||
|
||
Registry Disks are not a good solution for any workload that requires persistent | ||
disks across Virtual Machine restarts, or workloads that require Virtual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding to restarts, if it is just a restart on the same node, will it keep the data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, the only case where data will be reused is if the process was allowed to recover within the same virt-launcher cgroup.
registry-disk.md
Outdated
|
||
Users push Virtual Machine disks into the container registry using a KubeVirt | ||
base designed to work with the Registry Disk feature. The latest base container | ||
image is kubevirt.io/registry-disk-v1alpha. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you highlight kubevirt.io/registry-disk-v1alpha1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
registry-disk.md
Outdated
|
||
## When to use a Registry Disk | ||
|
||
Registry Disks are ephemeral storage devices that can be assigned to any number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is clear, if one thinks about the container registry re-use, but could you add one or two sentences, which make it more explicit, that no shared storage is needed, after the images are pulled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll add some more about this
Signed-off-by: David Vossel <davidvossel@gmail.com>
4350506
to
0406ced
Compare
Registry Disk user-guide and updates.
Requires kubevirt/kubevirt#460 to be merged first.