Expose the validator crate #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwctl uses validator too. When the `validator` version between kwctl and policy-evaluator is not the same, there could be compilation errors. This happens when the validator API breaks, like during the 0.15 to 0.16 upgrade. Currently we would have to bump `validator` inside of `policy_evaluator`, tag a new release and then update both the `validator` and the `policy_evaluator` versions inside of kwctl. By re-exposing the `validator` crate via the `policy_evaluator` we make the maintenance task easier. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
jvanz
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kwctl uses validator too. When the
validatorversion between kwctl and policy-evaluator is not the same, there could be compilation errors. This happens when the validator API breaks, like during the 0.15 to 0.16 upgrade.Currently we would have to bump
validatorinside ofpolicy_evaluator, tag a new release and then update both thevalidatorand thepolicy_evaluatorversions inside of kwctl.By re-exposing the
validatorcrate via thepolicy_evaluatorwe make the maintenance task easier.