Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle.require does not work without manual require because of non standart gem name #114

Closed
ailjushkin opened this issue Dec 28, 2015 · 3 comments

Comments

@ailjushkin
Copy link

Please, refer to rubygems/bundler#4190

I need to write:

gem 'ruby-oci8', :require => 'oci8'

to be able to autorequire this module in bundle.require

@ailjushkin ailjushkin changed the title bundle.require does not work because of non standart gem name bundle.require does not work without manual require because of non standart gem name Dec 28, 2015
@kubo
Copy link
Owner

kubo commented Dec 31, 2015

This issue will be easily fixed by adding ruby-oci8.rb containing require 'oci8'.
However I'm not sure whether I should add it.
If there were no workaround, I definitely done.
But there is a workaround as you wrote.
Give me time to think about it.

@ailjushkin
Copy link
Author

It is not a problem for me)

Anyway, just to think about it, gem naming convention:
http://guides.rubygems.org/name-your-gem/

But it is impossible to rename it, because everyone has to rewrite it in
gemfiles and/or in project files, so renaming is not good solution.

However, gemfile's require option is for that situations of non standart
naming.

So... I dont really think we can do something with oci8, actually...

Posted issue just to inform you...
Thanks anyway

чт, 31 дек. 2015, 17:37, Kubo Takehiro notifications@github.com:

This issue will be easily fixed by adding ruby-oci8.rb containing require
'oci8'.
However I'm not sure whether I should add it.
If there were no workaround, I definitely done.
But there is a workaround as you wrote.
Give me time to think about it.


Reply to this email directly or view it on GitHub
#114 (comment).

kubo added a commit that referenced this issue Mar 27, 2016
@kubo
Copy link
Owner

kubo commented Mar 27, 2016

ruby-oci8.rb was added. It just requires oci8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants