From 68d94c741f960fad359ce4085857e614c63b9ffe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Koz=C5=82owski?= Date: Thu, 14 Mar 2024 18:07:05 +0100 Subject: [PATCH] Don't make `f` cancelable --- modules/core/shared/src/main/scala/Trace.scala | 1 - 1 file changed, 1 deletion(-) diff --git a/modules/core/shared/src/main/scala/Trace.scala b/modules/core/shared/src/main/scala/Trace.scala index 9048bc85..8ddc1640 100644 --- a/modules/core/shared/src/main/scala/Trace.scala +++ b/modules/core/shared/src/main/scala/Trace.scala @@ -552,7 +552,6 @@ object Trace { override def span[A](name: String, options: Span.Options)(k: Resource[F, A]): Resource[F, A] = trace.spanR(name, options).flatMap { f => Resource.applyFull { cancelable => - // todo: should f be cancelable? does it matter? f(cancelable(k.allocatedCase)).map { case (a, release) => a -> release.andThen(f(_)) }