options for have_tag should also support Regexp #27

Merged
merged 2 commits into from Jan 10, 2014

Projects

None yet

2 participants

@iancanderson
Contributor

For backwards compatibility with RSpec 1.x, have_tag should also allow Regexp as the second parameter.
e.g.

"<h1>Title</h1>".should have_tag("h1", /itl/)

See http://old.rspec.info/rails/writing/views.html

@iancanderson iancanderson options for have_tag should also support Regexp
For backwards compatibility with RSpec 1.x, have_tag should also allow Regexp as the second parameter.
e.g. "<h1>Title</h1>".should have_tag("h1", /itl/)
See http://old.rspec.info/rails/writing/views.html
2a381ea
@kucaahbe
Owner

@iancanderson thanks, could you, please, add test for this functionality, so then I can merge.

@iancanderson
Contributor

@kucaahbe sure thing!

@iancanderson
Contributor

@kucaahbe specs are pushed and passing 😄
Any chance you could push a new version today so we can use the canonical gem? 🙏

@kucaahbe kucaahbe merged commit 3df2479 into kucaahbe:master Jan 10, 2014

1 check passed

default The Travis CI build passed
Details
@kucaahbe
Owner

@iancanderson thanks for your efforts! New version pushed:)

@iancanderson
Contributor

Perfect! and thanks for the quick turnaround. Yay opensource!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment