From cbdfb88dc583ccb1c86e1a96fc7bb72fa702a2e4 Mon Sep 17 00:00:00 2001 From: Marcin Owsiany Date: Fri, 20 Dec 2019 08:47:09 +0100 Subject: [PATCH] Improve test transparency. (#1209) * Show the actual binary which is run. * Show what commands are being run. This makes it easier to get the most focused command for the thing that is failing. --- hack/run-e2e-tests.sh | 1 + hack/run-integration-tests.sh | 1 + pkg/test/utils/kubernetes.go | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hack/run-e2e-tests.sh b/hack/run-e2e-tests.sh index 8cc0a3319..924b6ca96 100755 --- a/hack/run-e2e-tests.sh +++ b/hack/run-e2e-tests.sh @@ -3,6 +3,7 @@ set -o errexit set -o nounset set -o pipefail +set -o xtrace INTEGRATION_OUTPUT_JUNIT=${INTEGRATION_OUTPUT_JUNIT:-false} diff --git a/hack/run-integration-tests.sh b/hack/run-integration-tests.sh index b0a27b7e7..4a51c9ca4 100755 --- a/hack/run-integration-tests.sh +++ b/hack/run-integration-tests.sh @@ -3,6 +3,7 @@ set -o errexit set -o nounset set -o pipefail +set -o xtrace INTEGRATION_OUTPUT_JUNIT=${INTEGRATION_OUTPUT_JUNIT:-false} diff --git a/pkg/test/utils/kubernetes.go b/pkg/test/utils/kubernetes.go index 111d7a158..dc899c9b4 100644 --- a/pkg/test/utils/kubernetes.go +++ b/pkg/test/utils/kubernetes.go @@ -942,7 +942,7 @@ func RunCommands(logger Logger, namespace string, command string, commands []kud stdout := &bytes.Buffer{} stderr := &bytes.Buffer{} - logger.Log("Running command:", cmd) + logger.Logf("Running command: %s %s", command, cmd) err := RunCommand(context.TODO(), namespace, command, cmd, workdir, stdout, stderr) if err != nil {