make enable all eslint-plugin-jsx-a11y rules again #840
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for smarthr-ui ready! Built with commit 9ab580d |
cidermitaina
approved these changes
Jun 18, 2020
|
@masuP9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SmartHR UIでは eslint-plugin-jsx-a11y によるエラーが出てないので（すごい）、Smart HR UIでのみ lint ルールを復活させるのはどうでしょうか
kufu/eslint-config-smarthr を変更するには影響が大きすぎるためこのリポジトリで上書きしていますが、なるべく個別のリポジトリで上書きしたくない場合は教えてください。
https://github.com/kufu/eslint-config-smarthr/blob/master/configs/react.js#L38-L60
Since the SmartHR UI doesn't have an error by eslint-plugin-jsx-a11y (great), how about bring back the lint rule in the Smart HR UI.
The impact of changing the kufu/eslint\config-smarthr is too big to change, so I have to override the rules in this repository. But please let me know if you don't want to overwrite it as much as possible.