Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added Mousetrap reset whenever keybindings get reloaded. #8

Merged
merged 1 commit into from Sep 15, 2013

Conversation

Projects
None yet
3 participants
Contributor

thierry-rietsch commented Sep 14, 2013

It is required to reset the Mousetrap.js library as turbolinks does not refresh the page. Therefore some old keybindings might still be present.

To reproduce create the following steps:

  1. Create a page which lists all entities of type X (index.html.erb)
  2. Create a detail page for an entity of type X (show.html.erb) incl. an edit link (with keybinding 'e').
  3. Enable turbolinks
  4. Visit the index page, then navigate to one of the entities.
  5. Go back to the index page and press 'e'. You get now to the edit view of the previous visited entity.
@thierry-rietsch thierry-rietsch Added Mousetrap reset whenever keybindings get reloaded.
It is required to reset the Mousetrap.js library as turbolinks does not refresh the page. Therefore some old keybindings might still be present.
e422fc3

Coverage Status

Coverage decreased (-1.79%) when pulling e422fc3 on thierry-rietsch:master into fe31fe3 on kugaevsky:master.

@kugaevsky kugaevsky added a commit that referenced this pull request Sep 15, 2013

@kugaevsky kugaevsky Merge pull request #8 from thierry-rietsch/master
Added Mousetrap reset whenever keybindings get reloaded.
cd312a6

@kugaevsky kugaevsky merged commit cd312a6 into kugaevsky:master Sep 15, 2013

1 check passed

default The Travis CI build passed
Details
Owner

kugaevsky commented Sep 15, 2013

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment