Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix #19

Merged
merged 2 commits into from Mar 22, 2018

Conversation

@pilgwon
Copy link
Contributor

pilgwon commented Mar 19, 2018

In Character Set like Korean, In Example, 레드 goes 레ㄷㅡ and 베이지 goes ㅂㅔㅇㅣㅈㅣ. This bug fixed

@kuler90

This comment has been minimized.

Copy link
Owner

kuler90 commented Mar 21, 2018

Hi! Your fix looks a bit unclear 😀. Can you mark it with a comment?

@pilgwon

This comment has been minimized.

Copy link
Contributor Author

pilgwon commented Mar 22, 2018

Yes!

I modify this line

self.inputTextField.text = [tags lastObject];

to

if (![_inputTextField.text isEqualToString:tags.lastObject])
    self.inputTextField.text = [tags lastObject];

Thanks

@kuler90

This comment has been minimized.

Copy link
Owner

kuler90 commented Mar 22, 2018

I see that in your commit. I meant that you should add comments in your code about reason of these lines and update the PR. I think the fix is a bit tricky and can be unclear without commenting.

Thanks

@pilgwon

This comment has been minimized.

Copy link
Contributor Author

pilgwon commented Mar 22, 2018

Oh so sorry for misunderstood!
In example, If i write RED in English, this library clearly writes RED. If i write 레드 in korean (this mean red), this library writes ㄹㅔㄷㅡ.
I don't know how to write about this bug in shortly.
Combined Language Crash Bug Fix? Bug Fix for Korean? sorry for unclear :(

@kuler90

This comment has been minimized.

Copy link
Owner

kuler90 commented Mar 22, 2018

I think comment // Fix for Korean language - https://github.com/kuler90/RKTagsView/pull/19 alongside if will be good. Update the PR and I merge it.

Fix for Korean language - #19
@pilgwon

This comment has been minimized.

Copy link
Contributor Author

pilgwon commented Mar 22, 2018

OK! I modified the code :)

@kuler90 kuler90 merged commit dfb133a into kuler90:master Mar 22, 2018
@pilgwon

This comment has been minimized.

Copy link
Contributor Author

pilgwon commented Mar 22, 2018

Thanks! 👍

@kuler90

This comment has been minimized.

Copy link
Owner

kuler90 commented Mar 22, 2018

One more thing, this changes applied to the same version of pods (1.3.0) so you need run pod cache clean --all before pod install.

@pilgwon

This comment has been minimized.

Copy link
Contributor Author

pilgwon commented Mar 22, 2018

👍 💯 Got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.