Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): define 'ts-jest' on ConfigGlobals interface in @jest/types #1592

Merged
merged 1 commit into from May 4, 2020

Conversation

@ahnpnl
Copy link
Collaborator

ahnpnl commented May 4, 2020

Summary

  • Define ts-jest on jest ConfigGlobals interface to ultilize TypeScript declaration merging.
  • Adjust docs to instruct users how to do it.

Close #1588 , thanks @G-Rath for suggested solution 馃憤

Test plan

Build ts-jest then copy dist folder to node_modules/ts-jest/dist of an example project and follow the docs. Check if your IDE gives the suggestion of ts-jest config options.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@G-Rath
G-Rath approved these changes May 4, 2020
@coveralls
Copy link

coveralls commented May 4, 2020

Pull Request Test Coverage Report for Build 4673

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.865%

Totals Coverage Status
Change from base Build 4672: 0.0%
Covered Lines: 1067
Relevant Lines: 1103

馃挍 - Coveralls
@ahnpnl ahnpnl merged commit 4526392 into kulshekhar:next May 4, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage remained the same at 92.865%
Details
@ahnpnl ahnpnl deleted the ahnpnl:expose-ts-jest-global branch May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can鈥檛 perform that action at this time.