Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): don't set include property value of tsconfig to empty array #1606

Merged
merged 1 commit into from May 7, 2020

Conversation

@ahnpnl
Copy link
Collaborator

ahnpnl commented May 6, 2020

Summary

  • Revert #1562

  • Add doc to instruct how to boost performance and caveats

Close #1604
Close #1607
Close #1608

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner May 6, 2020
@ahnpnl
Copy link
Collaborator Author

ahnpnl commented May 6, 2020

@kulshekhar #1562 made lots of users happy but also lots of users not happy. Since the scale of breaking is quite large and it brings up some inconvenience, it's safer to revert #1562.

This PR is a hotfix 25.5.1. Later I will also merge this into master for 26 as well.

@ahnpnl ahnpnl linked an issue that may be closed by this pull request May 6, 2020
@coveralls
Copy link

coveralls commented May 6, 2020

Pull Request Test Coverage Report for Build 4716

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 92.916%

Totals Coverage Status
Change from base Build 4710: 0.05%
Covered Lines: 1067
Relevant Lines: 1102

💛 - Coveralls
@ahnpnl ahnpnl linked an issue that may be closed by this pull request May 7, 2020
}
```

## Caveats

This comment has been minimized.

Copy link
@ahnpnl

ahnpnl May 7, 2020

Author Collaborator

not sure if writing like this is fine. Would you please check ?

This comment has been minimized.

Copy link
@kulshekhar

kulshekhar May 7, 2020

Owner

This looks fine. It's basically your opinion on how this could be helpful under specific conditions. Nothing wrong with it

@ahnpnl ahnpnl merged commit 8a29aaa into kulshekhar:v25.5.1 May 7, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage increased (+0.05%) to 92.916%
Details
@ahnpnl ahnpnl deleted the ahnpnl:v25.5.1 branch May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.