Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): revert projectReferences related codes as not needed #1614

Merged
merged 1 commit into from May 9, 2020

Conversation

@ahnpnl
Copy link
Collaborator

ahnpnl commented May 8, 2020

Summary

We introduced projectReferences support in #1541 and #1527 . However, that was a misunderstanding when checking #766 .

This PR is to revert #1541 and #1527

This fix will be included in 25.5.1

Close #1613

Test plan

  • Adjust unit tests and e2e tests

  • Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner May 8, 2020
@ahnpnl ahnpnl linked an issue that may be closed by this pull request May 8, 2020
@ahnpnl ahnpnl mentioned this pull request May 8, 2020
1 of 2 tasks complete
@coveralls
Copy link

coveralls commented May 8, 2020

Pull Request Test Coverage Report for Build 4728

  • 28 of 28 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 92.893%

Totals Coverage Status
Change from base Build 4720: -0.02%
Covered Lines: 1061
Relevant Lines: 1096

💛 - Coveralls
@ahnpnl ahnpnl force-pushed the toggle-project-references branch from 32aaba7 to aef529c May 8, 2020
@ahnpnl ahnpnl changed the title fix(compiler): toggle `projectReferences` support by a ts-jest option fix(compiler): revert projectReferences related codes as not needed May 8, 2020
@ahnpnl ahnpnl merged commit 74b92d3 into v25.5.1 May 9, 2020
3 checks passed
3 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 92.893%
Details
@ahnpnl ahnpnl deleted the toggle-project-references branch May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.