Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): check if test file exists before doing type check #1827

Merged
merged 1 commit into from Jul 25, 2020

Conversation

@ahnpnl
Copy link
Collaborator

ahnpnl commented Jul 24, 2020

Summary

Addressed in #1506 (comment)

The problem is that the test file can be renamed which then makes the link between the imported module with the old test name no longer valid. Therefore we need to check whether the test file still exists before doing type check.

Test plan

Added unit test

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Will release alpha first and then hot fix release later

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner Jul 24, 2020
@coveralls
Copy link

coveralls commented Jul 24, 2020

Pull Request Test Coverage Report for Build 5427

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.721%

Totals Coverage Status
Change from base Build 5426: 0.0%
Covered Lines: 1056
Relevant Lines: 1091

💛 - Coveralls
@ahnpnl ahnpnl merged commit cc89d5b into kulshekhar:v26.1.4 Jul 25, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage remained the same at 92.721%
Details
@ahnpnl ahnpnl deleted the ahnpnl:v26.1.4 branch Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.